Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 992940 - Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators in Perl5
Summary: Review Request: perl-Syntax-Keyword-Junction - Perl6 style Junction operators...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 991773
TreeView+ depends on / blocked
 
Reported: 2013-08-05 09:04 UTC by Petr Pisar
Modified: 2013-08-05 13:24 UTC (History)
3 users (show)

Fixed In Version: perl-Syntax-Keyword-Junction-0.003004-1.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2013-08-05 13:24:52 UTC
jplesnik: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Petr Pisar 2013-08-05 09:04:58 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-Syntax-Keyword-Junction/perl-Syntax-Keyword-Junction.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-Syntax-Keyword-Junction/perl-Syntax-Keyword-Junction-0.003004-1.fc20.src.rpm
Description:
This is a lightweight module which provides 'Junction' operators, the most
commonly used being any and all. Inspired by the Perl6 design docs,
<http://dev.perl.org/perl6/doc/design/exe/E06.html>.

Fedora Account System Username: ppisar

Comment 1 Paul Howarth 2013-08-05 12:33:27 UTC
rpmlint output:

perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US http -> HTTP
perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US dev -> deb, derv, div
perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US exe -> ex, exes, exec
perl-Syntax-Keyword-Junction.noarch: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US http -> HTTP
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US dev -> deb, derv, div
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US exe -> ex, exes, exec
perl-Syntax-Keyword-Junction.src: W: spelling-error %description -l en_US html -> HTML, ht ml, ht-ml
2 packages and 0 specfiles checked; 0 errors, 8 warnings.

provides:

perl(Syntax::Feature::Junction) = 0.003004
perl(Syntax::Keyword::Junction) = 0.003004
perl(Syntax::Keyword::Junction::All) = 0.003004
perl(Syntax::Keyword::Junction::Any) = 0.003004
perl(Syntax::Keyword::Junction::Base) = 0.003004
perl(Syntax::Keyword::Junction::None) = 0.003004
perl(Syntax::Keyword::Junction::One) = 0.003004
perl-Syntax-Keyword-Junction = 0.003004-1.fc20

requires:

perl(:MODULE_COMPAT_5.18.0)
perl(Sub::Exporter::Progressive) >= 0.001006
perl(Syntax::Keyword::Junction)
perl(Syntax::Keyword::Junction::All)
perl(Syntax::Keyword::Junction::Any)
perl(Syntax::Keyword::Junction::Base)
perl(Syntax::Keyword::Junction::None)
perl(Syntax::Keyword::Junction::One)
perl(base)
perl(if)
perl(overload)
perl(strict)
perl(warnings)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

review checklist:

- rpmlint ok; the html and http acronyms could be capitalized but it's no blocker
- package and spec naming OK
- package meets guidelines
- license is (GPL+ or Artistic), same as upstream and OK for Fedora
- license text is bundled and packaged
- spec file written in English and is legible
- source matches upstream
- package builds fine in Rawhide
- build dependencies fully specified
- no locale data to worry about
- no libraries to worry about
- no bundled code present
- package is not intended to be relocatable
- directory ownership OK
- no duplicate files
- permissions OK
- macro usage is consistent
- package is code, not content
- no large docs
- docs don't affect runtime
- no devel bits to worry about
- not a GUI app, no desktop file needed
- filenames are all ASCII

Nits:

Should BR: at least version 0.88 of Test::More due to use of done_testing in t/syntax.t

APPROVED.

Comment 2 Jitka Plesnikova 2013-08-05 12:54:37 UTC
rpmlint ok
License ok
Build-requires ok
Binary requires ok
Binary provides ok
Package meets guidelines
Source matches upstream
Source0 is a working URL
Package builds fine
%check is present and all tests pass

Package is good.

Comment 3 Petr Pisar 2013-08-05 12:56:21 UTC
> Should BR: at least version 0.88 of Test::More due to use of done_testing in t/syntax.t

Indeed. I asked upstream to declare the version too <https://github.com/frioux/Syntax-Keyword-Junction/issues/6>.

Comment 4 Petr Pisar 2013-08-05 12:57:32 UTC
New Package SCM Request
=======================
Package Name: perl-Syntax-Keyword-Junction
Short Description: Perl6 style Junction operators in Perl5
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 5 Gwyn Ciesla 2013-08-05 13:04:24 UTC
Git done (by process-git-requests).

Comment 6 Petr Pisar 2013-08-05 13:24:52 UTC
Thank you for the reviews and the repository.


Note You need to log in before you can comment on or make changes to this bug.