Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 80820 - broken source code
Summary: broken source code
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: raidtools
Version: 8.0
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Doug Ledford
QA Contact: David Lawrence
Depends On:
TreeView+ depends on / blocked
Reported: 2002-12-31 18:01 UTC by d.binderman
Modified: 2007-04-18 16:49 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2004-11-27 23:18:32 UTC

Attachments (Terms of Use)

Description d.binderman 2002-12-31 18:01:43 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD  (Win98; I)

Description of problem:

Hello there,

I have just tried to compile raidtools-1.00.2-3.3 from Redhat 8.0

Here are some of the messages the compiler produces

cc: Info: scsi.c, line 277: In this statement, an array is being accessed outside the bounds specified for the array type. (subscrbounds)

Here is an untested patch to shut up the compiler.

./scsi.c.old ./scsi.c
*** ./scsi.c.old	Tue Dec 24 22:14:12 2002
--- ./scsi.c	Tue Dec 24 22:14:47 2002
*** 274,280 ****
      memcpy((void *)&sg_dev->revision[0], (const void *)&cmd.buf[32], 4);
      sg_dev->vendor[8] = '\0';
      sg_dev->product[16] = '\0';
!     sg_dev->revision[5] = '\0';
       * First try the device ID page.  Then get the serial number.
--- 274,280 ----
      memcpy((void *)&sg_dev->revision[0], (const void *)&cmd.buf[32], 4);
      sg_dev->vendor[8] = '\0';
      sg_dev->product[16] = '\0';
!     sg_dev->revision[ 4] = '\0';
       * First try the device ID page.  Then get the serial number.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. compile with any C compiler that checks array indexes, for example Compaq.

Additional info:

Note You need to log in before you can comment on or make changes to this bug.