Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 80764 - broken source code
Summary: broken source code
Alias: None
Product: Red Hat Linux
Classification: Retired
Component: netpbm
Version: 8.0
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Phil Knirsch
QA Contact: Ben Levenson
Depends On:
TreeView+ depends on / blocked
Reported: 2002-12-30 23:53 UTC by d.binderman
Modified: 2015-03-05 01:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2004-02-06 13:38:09 UTC

Attachments (Terms of Use)

Description d.binderman 2002-12-30 23:53:19 UTC
From Bugzilla Helper:
User-Agent: Mozilla/4.6 [en-gb]C-CCK-MCD  (Win98; I)

Description of problem:

Hello there,

I have just tried to compile netpbm-9.24-6 from Redhat 8.0

Here are some of the messages the compiler produces

cc: Info: /usr/src/redhat/BUILD/netpbm-9.24/ppm/ppmtoxpm.c, line 136: In this statement, an array is being accessed outside the bounds specified 
for the array type. (subscrbounds)

Here is an untested patch to shut up the compiler.

./ppm/ppmtoxpm.c.old ./ppm/ppmtoxpm.c
*** ./ppm/ppmtoxpm.c.old	Thu Dec 19 22:07:38 2002
--- ./ppm/ppmtoxpm.c	Thu Dec 19 22:08:53 2002
*** 132,139 ****
          static char name[80+1];
          char *cp;
!         strncpy(name, cmdline_p->input_filespec, sizeof(name));
!         name[sizeof(name)] = '\0';
          cp = strchr(name, '.');
          if (cp)
              *cp = '\0';     /* remove extension */
--- 132,139 ----
          static char name[80+1];
          char *cp;
!         strncpy(name, cmdline_p->input_filespec, sizeof(name) - 1);
!         name[sizeof(name) - 1] = '\0';
          cp = strchr(name, '.');
          if (cp)
              *cp = '\0';     /* remove extension */

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. compile with any C compiler that checks array indices, such as Compaq C

Additional info:

Comment 1 Phil Knirsch 2004-02-06 13:38:09 UTC
Has been fixed in latest rawhide version.

Read ya, Phil

Note You need to log in before you can comment on or make changes to this bug.