Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 597866 - Improve readability of the variables in ifplugd.action (patch)
Summary: Improve readability of the variables in ifplugd.action (patch)
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: ifplugd
Version: 13
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2010-05-30 20:24 UTC by Niels de Vos
Modified: 2010-11-05 20:17 UTC (History)
2 users (show)

Fixed In Version: ifplugd-0.28-15
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-11-05 20:17:33 UTC


Attachments (Terms of Use)
improve readability of ifplugd.action (deleted)
2010-05-30 20:24 UTC, Niels de Vos
no flags Details

Description Niels de Vos 2010-05-30 20:24:42 UTC
Created attachment 418091 [details]
improve readability of ifplugd.action

Description of problem:

$1 and $2 are easily mistaken and are not documented in the header of the file. Assigning clear variable names improved readability and makes it easier to change the script.


Version-Release number of selected component (if applicable):

ifplugd-0.28-14.fc12.x86_64 (fc12 comes with Fedora 13)

Comment 1 Niels de Vos 2010-11-05 20:17:33 UTC
Thanks for including this patch!

$ rpm -q --changelog ifplugd | head -n2
* Mon May 31 2010 José Matos <jamatos@fc.up.pt> - 0.28-15
- Add action readability patch (thanks to Niels de Vos) (bz#597866)


Note You need to log in before you can comment on or make changes to this bug.