Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 466879 - Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounceable passwords
Summary: Package Review: perl-Crypt-GeneratePassword - Generate secure random pronounc...
Status: CLOSED DUPLICATE of bug 452458
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: F-Spacewalk
TreeView+ depends on / blocked
Reported: 2008-10-14 10:39 UTC by Miroslav Suchý
Modified: 2008-12-03 12:18 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-12-03 12:18:57 UTC
tibbs: fedora-review+
huzaifas: fedora-cvs+

Attachments (Terms of Use)

Description Miroslav Suchý 2008-10-14 10:39:33 UTC
Crypt::GeneratePassword generates random passwords that are (more or less)
pronounceable. Unlike Crypt::RandPasswd, it doesn't use the FIPS-181 NIST
standard, which is proven to be insecure. It does use a similar interface,
so it should be a drop-in replacement in most cases.

Scratch build:

$ rpmlint perl-Crypt-GeneratePassword-0.03-3.fc10.noarch.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
$ rpmlint perl-Crypt-GeneratePassword-0.03-3.fc10.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jason Tibbitts 2008-10-17 20:29:18 UTC
Not much to say here, really.  I guess I could point out that most people tend to prefer calling iconv over patching to fix utf8 issues, but that's up to you.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* rpmlint is silent.
* final provides and requires are sane:
   perl(Crypt::GeneratePassword) = 0.03
   perl-Crypt-GeneratePassword = 0.03-3.fc10

* %check is present and the one test passes.  It's about the minimal useful test 
   suite you can get for a Perl module, but it's there.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


The package review process needs reviewers!  If you haven't done any package
reviews recently, please consider doing one.

Comment 2 Miroslav Suchý 2008-10-21 12:21:59 UTC
New Package CVS Request
Package Name: perl-Crypt-GeneratePassword
Short Description: Generate secure random pronounceable passwords
Owners: msuchy
Branches: devel F-9 F-10 EL-4 EL-5 
Cvsextras Commits: yes

Comment 3 Huzaifa S. Sidhpurwala 2008-10-22 10:34:42 UTC
cvs done

Comment 4 Jason Tibbitts 2008-12-02 23:25:14 UTC
Any reason this ticket is still open?

Comment 5 Miroslav Suchý 2008-12-03 11:33:41 UTC
Hmm, there is one problem.
We both missed that is package is already included:
But it now bring the situation that I'm owner of F-10, F-9, EL-4 and  EL-5 branch. And nigelj is owner of devel and F-8.

Comment 6 Miroslav Suchý 2008-12-03 12:18:57 UTC

*** This bug has been marked as a duplicate of bug 452458 ***

Note You need to log in before you can comment on or make changes to this bug.