Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 456362 - Review Request: perl-DBIx-Class-Schema-Loader - Dynamic definition of a DBIx::Class::Schema
Summary: Review Request: perl-DBIx-Class-Schema-Loader - Dynamic definition of a DBIx:...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://search.cpan.org/dist/DBIx-Clas...
Whiteboard:
Depends On:
Blocks: 454029
TreeView+ depends on / blocked
 
Reported: 2008-07-23 06:00 UTC by Chris Weyl
Modified: 2010-09-02 21:21 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-07-23 23:58:12 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Chris Weyl 2008-07-23 06:00:54 UTC
SRPM URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-Schema-Loader-0.04005-1.fc9.src.rpm
SPEC URL: http://fedora.biggerontheinside.net/review/perl-DBIx-Class-Schema-Loader.spec

Description:
DBIx::Class::Schema::Loader automates the definition of a
DBIx::Class::Schema by scanning database table definitions
and setting up the columns, primary keys, and relationships.

Comment 1 Parag AN(पराग) 2008-07-23 08:08:32 UTC
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=733382
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d9e112493df06800862b93bf46760c4f  DBIx-Class-Schema-Loader-0.04005.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=13, Tests=238, 13 wallclock secs ( 0.05 usr  0.02 sys +  1.58 cusr  0.35
csys =  2.00 CPU)

+ Package perl-DBIx-Class-Schema-Loader-0.04005-1.fc10 =>
Provides:
 perl(DBIx::Class::Schema::Loader) = 0.04005
perl(DBIx::Class::Schema::Loader::Base) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::DB2) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::Pg) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::SQLite) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::Writing) = 0.04005
perl(DBIx::Class::Schema::Loader::DBI::mysql) = 0.04005
perl(DBIx::Class::Schema::Loader::RelBuilder) = 0.04005

Requires: perl(Carp::Clan) perl(Class::C3) perl(Cwd) perl(DBIx::Class)
perl(DBIx::Class::Schema::Loader::RelBuilder) perl(Data::Dump) perl(Digest::MD5)
perl(File::Spec) perl(Lingua::EN::Inflect::Number) perl(POSIX)
perl(Scalar::Util) perl(Text::Balanced) perl(UNIVERSAL::require) perl(base)
perl(strict) perl(warnings)

APPROVED.

Comment 2 Chris Weyl 2008-07-23 14:44:11 UTC
New Package CVS Request
=======================
Package Name: perl-DBIx-Class-Schema-Loader
Short Description: Dynamic definition of a DBIx::Class::Schema
Owners: cweyl
Branches: F-8, F-9, devel
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2008-07-23 16:01:44 UTC
cvs done.

Comment 4 Chris Weyl 2008-07-23 23:58:12 UTC
Imported and building.  Thanks for the review! :)

Comment 5 Iain Arnell 2010-09-02 14:31:42 UTC
Package Change Request
======================
Package Name: perl-DBIx-Class-Schema-Loader
New Branches: el6
Owners: iarnell tremble

Comment 6 Kevin Fenzi 2010-09-02 21:21:40 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.