Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 455575 - Review Request: dbus-c++ - Native C++ bindings for D-Bus
Summary: Review Request: dbus-c++ - Native C++ bindings for D-Bus
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Dan Horák
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-07-16 11:32 UTC by Adel Gadllah
Modified: 2008-07-16 17:29 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-07-16 17:29:02 UTC
dan: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Adel Gadllah 2008-07-16 11:32:41 UTC
Spec URL: http://tgmweb.at/gadllah/dbus-c++.spec
SRPM URL: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.1.20080716git.fc9.src.rpm
Description: 
Native C++ bindings for D-Bus for use in C++ programs.

Comment 1 Dan Horák 2008-07-16 11:46:16 UTC
Can you change the snapshot generation to include last commit id? You can see
http://cvs.fedoraproject.org/viewcvs/rpms/xorg-x11-drv-nouveau/devel/xorg-x11-drv-nouveau.spec?rev=1.4&view=auto
for an example.

Comment 3 Dan Horák 2008-07-16 13:38:50 UTC
formal review:

OK	source files match upstream
OK	package meets naming and versioning guidelines.
OK	specfile is properly named, is cleanly written and uses macros consistently.
OK	dist tag is present.
OK	build root is correct.
OK	license field matches the actual license.
OK	license is open source-compatible (LGPLv2+). License text included in package.
OK	latest version is being packaged.
OK	BuildRequires are proper.
BAD	compiler flags are appropriate.
OK	%clean is present.
OK	package builds in mock (Rawhide/x86_64).
BAD	debuginfo package looks complete.
OK	rpmlint is silent.
OK	final provides and requires look sane.
N/A	%check is present and all tests pass.
OK	shared libraries are added to the regular linker search paths, correct
scriptlets exists
OK	owns the directories it creates.
OK	doesn't own any directories it shouldn't.
OK	no duplicates in %files.
OK	file permissions are appropriate.
OK	correct scriptlets present.
OK	code, not content.
OK	documentation is small, so no -docs subpackage is necessary.
OK	%docs are not necessary for the proper functioning of the package.
OK	headers in devel subpackage.
OK	pkgconfig files in devel subpackage.
OK	no libtool .la droppings.
OK	not a GUI app.


- wrong flags are passed to the compiler, looks like package's own
- can't see any source files in the debuginfo package (depends on the flags issue)
- and I would use the git-archive to generate the source archive, but that's not
any blocker, it would decrease the size from 750 KB to only 50 KB ;-)


Comment 4 Adel Gadllah 2008-07-16 14:25:57 UTC
(In reply to comment #3)
> formal review:

> BAD	compiler flags are appropriate.
Fixed.

> BAD	debuginfo package looks complete.
Fixed.

> - wrong flags are passed to the compiler, looks like package's own
Fixed now. (see above)
> - can't see any source files in the debuginfo package (depends on the flags issue)
Fixed too.
> - and I would use the git-archive to generate the source archive, but that's not
> any blocker, it would decrease the size from 750 KB to only 50 KB ;-)
Done.

New spec: http://tgmweb.at/gadllah/dbus-c++.spec
New SRPM: http://tgmweb.at/gadllah/dbus-c++-0.5.0-0.3.20080716git1337c65.fc9.src.rpm


Comment 5 Dan Horák 2008-07-16 14:47:18 UTC
looks OK now, so this package is APPROVED

Comment 6 Adel Gadllah 2008-07-16 14:59:40 UTC
Thanks for the review.
---------
New Package CVS Request
=======================
Package Name: dbus-c++
Short Description: Native C++ bindings for D-Bus
Owners: drago01
Branches: F-8 F-9
InitialCC:
Cvsextras Commits: yes


Comment 7 Kevin Fenzi 2008-07-16 16:13:20 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.