Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 454364 - libSAD API headers are broken
Summary: libSAD API headers are broken
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: audacious
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Ralf Ertzinger
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 453026 465081
TreeView+ depends on / blocked
 
Reported: 2008-07-07 23:33 UTC by Michael Schwendt
Modified: 2008-10-16 12:06 UTC (History)
1 user (show)

Fixed In Version: audacious-1.5.1-3
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-10-16 12:06:32 UTC


Attachments (Terms of Use)

Description Michael Schwendt 2008-07-07 23:33:00 UTC
audacious-devel-1.5.1-2.fc10.i386.rpm

libSAD header common.h evaluates external autoconf
macros (here HAVE_CONFIG_H) and tries to include a
non-existant config.h header. Something like that
does not belong into a library API. As reported 
in FTBFS summary on fedora-devel:

In file included from /usr/include/libSAD/libSAD.h:23
,
                 from /usr/include/audacious/util.h:41
,
                 from configure.c:2
:
/usr/include/libSAD/common.h:38:21:
 
error: 
config.h: No such file or directory

Comment 1 Ralf Ertzinger 2008-08-21 19:20:17 UTC
Those files are not meant to be installed for the 1.5 release, I'll drop them as soon as the build sys works again

Comment 2 Michael Schwendt 2008-09-24 15:27:51 UTC
util.h:#include "libSAD/libSAD.h"

Comment 3 Dominik 'Rathann' Mierzejewski 2008-10-13 18:37:26 UTC
And, to give a real example of breakage after libSAD.h is removed:

In file included from audacious.c:19:
/usr/include/audacious/util.h:41:27: error: libSAD/libSAD.h: No such file or directory
In file included from audacious.c:19:
/usr/include/audacious/util.h:94: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'sadfmt_from_afmt'

This is from xmp build (bug 453026).

Comment 4 Michael Schwendt 2008-10-16 12:06:32 UTC
Just built audacious-plugin-fc in rawhide without errors.


Note You need to log in before you can comment on or make changes to this bug.