Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 452472 - Review-Request: perl-TAP-Harness-Archive - Create an archive of TAP test results
Summary: Review-Request: perl-TAP-Harness-Archive - Create an archive of TAP test results
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL: http://netbsd.sk/~lkundrak/SPECS/perl...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-23 07:58 UTC by Lubomir Rintel
Modified: 2008-06-23 19:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-23 19:04:03 UTC
panemade: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Lubomir Rintel 2008-06-23 07:58:46 UTC
SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-TAP-Harness-Archive.spec
SRPM:
http://netbsd.sk/~lkundrak/mock-results/perl-TAP-Harness-Archive-0.03-1.el5.noarch/perl-TAP-Harness-Archive-0.03-1.el5.src.rpm
mock:
http://netbsd.sk/~lkundrak/mock-results/perl-TAP-Harness-Archive-0.03-1.el5.noarch/

Description:

This module is a direct subclass of TAP::Harness and behaves in exactly the
same way except for one detail. In addition to outputting a running progress
of the tests and an ending summary it can also capture all of the raw TAP
from the individual test files or streams into an archive file (.tar or
.tar.gz).

Comment 1 Parag AN(पराग) 2008-06-23 08:28:37 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=676055
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
5a92a2ae5b434692295555a68146703d  TAP-Harness-Archive-0.03.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful.
Files=3, Tests=26,  1 wallclock secs ( 1.03 cusr +  0.09 csys =  1.12 CPU)
+ Package perl-TAP-Harness-Archive-0.03-1.fc10 =>
Provides: perl(TAP::Harness::Archive) = 0.03
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Archive::Tar) perl(Cwd)
perl(File::Basename) perl(File::Find) perl(File::Path) perl(File::Spec)
perl(File::Temp)
 perl(TAP::Harness) >= 3.05 perl(TAP::Parser) perl(YAML::Tiny) perl(base)
perl(strict) perl(warnings)


APPROVED.

Comment 2 Lubomir Rintel 2008-06-23 08:35:00 UTC
New Package CVS Request
=======================
Package Name: perl-TAP-Harness-Archive
Short Description: Create an archive of TAP test results
Owners: lkundrak
Branches: F-9 F-8 EL-5
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-06-23 15:47:15 UTC
cvs done.

Comment 4 Lubomir Rintel 2008-06-23 19:04:03 UTC
Thanks Parag, thanks Kevin.
Imported and built.


Note You need to log in before you can comment on or make changes to this bug.