Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 452471 - Review-Request: perl-Test-Mock-LWP - Easy mocking of LWP packages
Summary: Review-Request: perl-Test-Mock-LWP - Easy mocking of LWP packages
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
Depends On:
Blocks: 452470
TreeView+ depends on / blocked
Reported: 2008-06-23 07:57 UTC by Lubomir Rintel
Modified: 2008-06-23 19:04 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2008-06-23 19:04:04 UTC
panemade: fedora-review+
kevin: fedora-cvs+

Attachments (Terms of Use)

Description Lubomir Rintel 2008-06-23 07:57:39 UTC


This package arises from duplicating the same code to mock LWP et al in
several different modules I've written. This version is very minimalist,
but works for my needs so far. I'm very open to new suggestions and

(TODO: Now I see this description sucks. I'll replace it when updating the package.)

Comment 1 Parag AN(पराग) 2008-06-23 08:17:32 UTC
+ package builds in mock.
Koji build =>
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
2496324cd4474966269847836770b7a0  Test-Mock-LWP-0.05.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful.
Files=2, Tests=11,  0 wallclock secs ( 0.07 cusr +  0.01 csys =  0.08 CPU)
+ Package perl-Test-Mock-LWP-0.05-1.fc10 =>
  Provides: perl(HTTP::Request) perl(HTTP::Response) perl(LWP::UserAgent)
perl(Test::Mock::HTTP::Request) = 0.01 perl(Test::Mock::HTTP::Response) = 0.01
perl(Test::Mock::LWP) = 0.05 perl(Test::Mock::LWP::UserAgent) = 0.01

Requires: perl(:MODULE_COMPAT_5.10.0) perl(Test::Mock::HTTP::Request)
 perl(Test::Mock::HTTP::Response) perl(Test::MockObject) perl(base) perl(strict)


Comment 2 Lubomir Rintel 2008-06-23 08:25:57 UTC
Thanks Parag!

New Package CVS Request
Package Name: perl-Test-Mock-LWP
Short Description: Easy mocking of LWP packages
Owners: lkundrak
Branches: F-8 F-9 EL-5
Cvsextras Commits: yes

Comment 3 Kevin Fenzi 2008-06-23 15:44:14 UTC
cvs done.

Comment 4 Lubomir Rintel 2008-06-23 19:04:04 UTC
Thanks Parag, thanks Kevin.
Imported and built.

Note You need to log in before you can comment on or make changes to this bug.