Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 452456 - Review Request: perl-DateTime-TimeZone - Time zone object base class and factory
Summary: Review Request: perl-DateTime-TimeZone - Time zone object base class and factory
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-Spacewalk
TreeView+ depends on / blocked
 
Reported: 2008-06-23 03:29 UTC by Nigel Jones
Modified: 2008-06-23 09:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-23 08:43:36 UTC


Attachments (Terms of Use)

Description Nigel Jones 2008-06-23 03:29:15 UTC
Spec URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone.spec
SRPM URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone-0.7701-1.fc9.src.rpm
Description: 
This class is the base class for all time zone objects. A time zone is
represented internally as a set of observances, each of which describes the
offset from GMT for a given time period.

Comment 1 Parag AN(पराग) 2008-06-23 05:13:52 UTC
rpmlint gave 
perl-DateTime-TimeZone.noarch: E: useless-explicit-provides perl(DateTime::TimeZone)
This package provides 2 times the same capacity. It should only provide it
once.
==> look
https://fedoraproject.org/wiki/Packaging/Perl#Filtering_Requires:_and_Provides

Comment 2 Nigel Jones 2008-06-23 05:41:02 UTC
(In reply to comment #1)
> rpmlint gave 
> perl-DateTime-TimeZone.noarch: E: useless-explicit-provides
perl(DateTime::TimeZone)
> This package provides 2 times the same capacity. It should only provide it
> once.
> ==> look
> https://fedoraproject.org/wiki/Packaging/Perl#Filtering_Requires:_and_Provides
Yeah, for public record... I'm a dummy...

Spec URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone.spec
SRPM URL: http://dev.nigelj.com/SRPMS/perl-DateTime-TimeZone-0.7701-2.fc9.src.rpm

Just the provides script fix

Comment 3 Parag AN(पराग) 2008-06-23 05:58:40 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675992
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
cf56d3770231d59853f4edcd6b56cc45  DateTime-TimeZone-0.7701.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful, 1 test and 26 subtests skipped.
Files=18, Tests=2812,  7 wallclock secs ( 6.91 cusr +  0.19 csys =  7.10 CPU)

APPROVED.

Comment 4 Nigel Jones 2008-06-23 07:33:35 UTC
(In reply to comment #3)
> APPROVED.

Thanks

New Package CVS Request
=======================
Package Name: perl-DateTime-TimeZone
Short Description: Time zone object base class and factory
Owners: nigelj
Branches: F-8 F-9 EL-4 EL-5
InitialCC: perl-sig
Cvsextras Commits: yes


Comment 5 Paul Howarth 2008-06-23 08:17:52 UTC
This package will almost certainly conflict with the perl-DateTime package that
it is enhancing, since the perl-DateTime package includes the DateTime::TimeZone
and DateTime::Locale modules too; see Bug #167376.

Comment 6 Parag AN(पराग) 2008-06-23 08:32:11 UTC
oops my bad. I just checked this package exists in fedora using
yum search DateTime

Comment 7 Parag AN(पराग) 2008-06-23 08:43:36 UTC
Just looked into perl-DateTime.spec and found that this package is part of
existing perl-DateTime package in fedora.
In this case I am going to CLOSE this review as NOTABUG.
Sorry Nigel for taking your time to update initial submitted package.
Request you to submit a bug to update perl-DateTime-TimeZone in perl-DateTime
package to 0.7701 version.

Comment 8 Paul Howarth 2008-06-23 09:00:59 UTC
(In reply to comment #7)
> Request you to submit a bug to update perl-DateTime-TimeZone in perl-DateTime
> package to 0.7701 version.

I'd also request that perl-DateTime had "provides" for perl-DateTime-TimeZone
and perl-DateTime-Locale too.


Note You need to log in before you can comment on or make changes to this bug.