Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 452455 - Review Request: perl-DateTime-Locale - Localization support for DateTime.pm
Summary: Review Request: perl-DateTime-Locale - Localization support for DateTime.pm
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F-Spacewalk
TreeView+ depends on / blocked
 
Reported: 2008-06-23 03:26 UTC by Nigel Jones
Modified: 2008-06-23 08:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-23 08:41:09 UTC


Attachments (Terms of Use)

Description Nigel Jones 2008-06-23 03:26:13 UTC
Spec URL: http://dev.nigelj.com/SRPMS/perl-DateTime-Locale.spec
SRPM URL: http://dev.nigelj.com/SRPMS/perl-DateTime-Locale-0.4001-1.fc9.src.rpm
Description:
DateTime::Locale is primarily a factory for the various locale subclasses.
It also provides some functions for getting information on all the
available locales.

Comment 1 Parag AN(पराग) 2008-06-23 04:53:17 UTC
remove BR: perl from SPEC
Is cldr license approved license? I don't see its mentioned on Licensing page. 

Comment 2 Parag AN(पराग) 2008-06-23 04:55:51 UTC
Also, build failed as missing BR:perl(Test::More)
see http://koji.fedoraproject.org/koji/taskinfo?taskID=675973

Comment 3 Nigel Jones 2008-06-23 05:13:49 UTC
(In reply to comment #1)
> remove BR: perl from SPEC
Done
> Is cldr license approved license? I don't see its mentioned on Licensing page. 
I suspect this is out of date, I'll have a look around and see.
(In reply to comment #2)
> Also, build failed as missing BR:perl(Test::More)
> see http://koji.fedoraproject.org/koji/taskinfo?taskID=675973
Fixed 
Spec URL: http://dev.nigelj.com/SRPMS/perl-DateTime-Locale.spec
SRPM URL: http://dev.nigelj.com/SRPMS/perl-DateTime-Locale-0.4001-2.fc9.src.rpm

Lets see about the licensing situation though.


Comment 4 Parag AN(पराग) 2008-06-23 05:36:11 UTC
Review:
+ package builds in mock.
Koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=675976
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
04cd7e65e4c773dfce972699aafc1f64  DateTime-Locale-0.4001.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test is ok.
All tests successful, 2 tests and 1 subtest skipped.
Files=10, Tests=9379,  4 wallclock secs ( 3.87 cusr +  0.13 csys =  4.00 CPU)

Except license everything else look ok to me. my question is can we see if CLDR
license can be approved license and can we specify it in License tag also?


Comment 5 Parag AN(पराग) 2008-06-23 05:38:09 UTC
I missed rpmlint output in above review. you need to work on following warning 
perl-DateTime-Locale.noarch: W: file-not-utf8
/usr/share/doc/perl-DateTime-Locale-0.4001/Changes
The character encoding of this file is not UTF-8.  Consider converting it
in the specfile for example using iconv(1).
==> use iconv to fix 

Comment 6 Paul Howarth 2008-06-23 08:14:15 UTC
The DateTime::Locale (and DateTime::TimeZone) modules are packaged bundled with
DateTime in Fedora already. See Bug #167376.

Comment 7 Parag AN(पराग) 2008-06-23 08:33:40 UTC
oops my bad. I just checked this package exists in fedora using
yum search DateTime

I should have checked its contents first before doing review of this package.

Comment 8 Parag AN(पराग) 2008-06-23 08:41:09 UTC
Just looked into perl-DateTime.spec and found that this package is part of
existing perl-DateTime package in fedora.
In this case I am going to CLOSE this review as NOTABUG.
Sorry Nigel for taking your time to update initial submitted package.


Note You need to log in before you can comment on or make changes to this bug.