Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 451925 - Review Request: synce-hal - Connection framework and dccm-implementation
Summary: Review Request: synce-hal - Connection framework and dccm-implementation
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2008-06-18 08:12 UTC by Andreas Bierfert
Modified: 2008-06-19 05:58 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-06-19 05:58:36 UTC
panemade: fedora-review+
tibbs: fedora-cvs+


Attachments (Terms of Use)

Description Andreas Bierfert 2008-06-18 08:12:09 UTC
Spec URL: http://fedora.lowlatency.de/review/synce-hal.spec
SRPM URL: http://fedora.lowlatency.de/review/synce-hal-0.1-1.fc8.src.rpm
Description:
Synce-hal is a connection framework and dccm-implementation 
for Windows Mobile devices that integrates with HAL.

Comment 1 Andreas Bierfert 2008-06-18 08:22:15 UTC
Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=667706

Comment 2 Parag AN(पराग) 2008-06-18 08:53:14 UTC
Review:-
+ package builds in mock.
+ You like to use macros in Source URL
http://downloads.sourceforge.net/synce/%{name}-%{version}.tar.gz
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
77ea51506ac4ef2bdb81ba7f5c609d2b  synce-hal-0.1.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.

APPROVED.


Comment 3 Andreas Bierfert 2008-06-18 09:37:50 UTC
Thanks for the quick review!

New Package CVS Request
=======================
Package Name: synce-hal
Short Description: Connection framework and dccm-implementation
Owners: awjb
Branches: F-8 F-9
Cvsextras Commits: yes


Comment 4 Jason Tibbitts 2008-06-19 02:52:49 UTC
CVS done.


Note You need to log in before you can comment on or make changes to this bug.