Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 441154 - Missing default face icon
Summary: Missing default face icon
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: kdebase-workspace
Version: rawhide
Hardware: All
OS: Linux
low
low
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 441167
TreeView+ depends on / blocked
 
Reported: 2008-04-06 21:33 UTC by Sebastian Vahl
Modified: 2008-04-07 16:30 UTC (History)
4 users (show)

Fixed In Version: 4.0.3-7.fc9
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2008-04-07 16:30:32 UTC


Attachments (Terms of Use)

Description Sebastian Vahl 2008-04-06 21:33:31 UTC
Description of problem:
In kdebase3 we use a symbolic link to define a default face icon:

# own %{_datadir}/apps/kdm/faces
mkdir -p %{buildroot}%{_datadir}/apps/kdm/faces
pushd %{buildroot}%{_datadir}/apps/kdm/faces
ln -sf ../pics/users/default1.png .default.face.icon
popd

kdebase4 is missing this symbolic link. So if we ever have a theme with a user 
list, it would be good to have a default face icon for all users.

Comment 1 Kevin Kofler 2008-04-07 12:39:21 UTC
This file should still be there, only it's %{_kde4_appsdir} now instead 
of %{_datadir}/apps.

Comment 2 Kevin Kofler 2008-04-07 12:40:41 UTC
Oh, actually you mean the symbolic link itself is missing. That's easy to add.

Comment 3 Sebastian Vahl 2008-04-07 14:18:32 UTC
(In reply to comment #2)
> Oh, actually you mean the symbolic link itself is missing. That's easy to 
add.

Indeed. I think we've only missed to also add this from kdebase.spec to 
kdebase-workspace.spec. (I've really forgotten about that when packaging 
kdebase-workspace)



Comment 4 Kevin Kofler 2008-04-07 14:20:09 UTC
I'm going to fix this.

Comment 5 Rex Dieter 2008-04-07 14:23:13 UTC
could also be added to kde-settings (so we don't force a rebuild of all of
kdebase-workspace).  Has the added benefit of allowing sites to "theme" their
face icons (by providing their own kde-settings).

Comment 6 Kevin Kofler 2008-04-07 14:32:45 UTC
Well, the icons are in kdebase-workspace, so we'd either leave a dangling 
symlink in kde-settings or have to require kdebase-workspace from kde-settings.

Comment 7 Ngo Than 2008-04-07 14:44:58 UTC
we have to avoid dangling symlink as we can. I'm against dangling symlink in 
kde-settings

Comment 8 Rex Dieter 2008-04-07 14:52:50 UTC
imo, dangling symlink would be harmless.  the face icons are only useful when/if
kdebase-workspace is installed anyway.

Shrug, like I said in irc, either way works. :)


Note You need to log in before you can comment on or make changes to this bug.