Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 234566 - RFE: some specfile improvements
Summary: RFE: some specfile improvements
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: tuxpuck
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-03-30 06:17 UTC by Hans de Goede
Modified: 2007-11-30 22:12 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-03-30 12:32:12 UTC


Attachments (Terms of Use)

Description Hans de Goede 2007-03-30 06:17:46 UTC
Hi,

I made the mistake to package tuxpuck myself while it was already packaged. I
cannot believe this as I even was actively involved in finding a new owner for
all of Hugo's packages :( If you're interested see bug 234307

Anyways to not let this be a complete waste of time, I've compared Hugo's
specfile with mine, and here are some suggested improvements:

Real improvements
-----------------
* I don't know where the png now used as icon comes from, but tucpuck comes
  with its own (IMHO better) icon. To use this:
1) Add a BuildRequires ImageMagick
2) Add "convert -transparent white data/icons/%{name}.ico %{name}.png"
   to the end of %build
3) Change the icon "install" command to install %{name}.png instead of
   %{SOURCE2}
4) Search replace 48x48 with 32x32
5) Drop the Source2: tag

* I don't know if you are aware of this, but there is a special package to
divide the games menu in many submenus based on the categories in the .desktop
file, see:
https://www.redhat.com/archives/fedora-games-list/2007-March/msg00003.html

In order for this to work properly its important that the .desktop file 
contains descriptive categories. Can you please change the Categories=...
line into: "Categories=Game;ArcadeGame;SportsGame;" Iow add "SportsGame;" and
while you are at it drop the invalid "Application" Category

More Cosmetic improvements
--------------------------
* Drop the obsolete "--add-category X-Fedora" from the desktop-file-install 
  command
* Change the iconcache scriptlets from: "
touch --no-create %{_datadir}/icons/hicolor || :
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
   %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
" into the now standard: "
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
"
* Add a: "Requires: hicolor-icon-theme" for proper /usr/share/icons/... 
  directory ownership.

Comment 1 Gwyn Ciesla 2007-03-30 12:32:12 UTC
All changes made, committed and built for 5,6 and dev.

Thanks for the suggestions!


Note You need to log in before you can comment on or make changes to this bug.