Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 231674 - Review Request: libmimedir - Library to parse MIME Directory Profile
Summary: Review Request: libmimedir - Library to parse MIME Directory Profile
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Andreas Bierfert
QA Contact: Fedora Package Reviews List
Depends On:
Blocks: 231675
TreeView+ depends on / blocked
Reported: 2007-03-09 22:13 UTC by Aurelien Bompard
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-05-01 21:22:29 UTC
andreas.bierfert: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Aurelien Bompard 2007-03-09 22:13:39 UTC
Spec URL:
This library parses MIME Directory Profile which is defined in RFC 2425.

This library is part of SynCE. SynCE is already in Fedora Extras, but in the form of a monolithic package : all the libraries are in the same RPM. I've splitted it, this is one of the libraries.
This package produces a static library, because it is the default behaviour in the Makefile and I can't get SynCE to compile if I force the creation of a shared library

Comment 1 Aurelien Bompard 2007-04-02 09:09:23 UTC
* Mon Apr 02 2007 Aurelien Bompard <> 0.4-2
- make a -static package

Comment 2 Andreas Bierfert 2007-04-27 09:18:46 UTC
* OK: rpmlint output: W: libmimedir-devel no-documentation can be ignored
 * NOTOK: E: libmimedir-debuginfo empty-debuginfo-package should probably be fixed
 * OK: package is named according to the guidelines
 * OK: spec file name matches base package name
 * OK: package meets packaging guidelines
 * OK: license
 * OK: license field matches actual license
 * OK: license is not included as own file and thus is not included in %doc
 * OK: Spec file seems to be in AE
 * OK: no obfuscated code spec
 * OK: sources match upstream:
156e1eb69377d9ae9180a09e38148ec6  libmimedir-0.4.tar.gz
156e1eb69377d9ae9180a09e38148ec6  /homes/awjb/rpmbuild/SOURCES/libmimedir-0.4.tar.gz
 * OK: Builds fine on x86_64/fc6
 * OK: BR seem fine
 * OK: package has no locale support
 * OK: package does not contain a shared library 
 * OK: package is not explicitly designed to be relocatable
 * OK: package does not create any directories
 * OK: no duplicate files in file listing
 * OK: %defattr and permissions seem ok
 * OK: %clean section is present
 * OK: macros are used consistently
 * OK: content is ok
 * OK: no doc package needed
 * OK: %doc files do not affect runtime
 * OK: header files are in -devel
 * OK: static lib in -static
 * OK: pkgconfig is not needed
 * OK: no .so file
 * OK: -devel requires main package
 * OK: package does not contain .la archives
 * OK: no .desktop needed
 * OK: does not own files/directories from other packages
 * OK: buildroot is rm at beginning of install
 * OK: filenames seem to be valid utf8

The debuginfo package is empty so either turn of the generation of the
debuginfo package or (better) fix the generation.

Other then that consider the package 8edf3312a0ab5b68bf670b50ed2b4f89 
libmimedir-0.4-2.src.rpm APPROVED with the following patch:

--- libmimedir.spec.1	2007-04-27 11:05:23.000000000 +0200
+++ libmimedir.spec	2007-04-27 10:58:24.000000000 +0200
@@ -34,32 +34,23 @@
 CFLAGS="$RPM_OPT_FLAGS -fPIC" %configure 
 make %{?_smp_mflags}
-# build shared libmimedir to work around x86_64 build error
-#ld --shared --whole-archive libmimedir.a -o
-#rm libmimedir.a
 mkdir -p $RPM_BUILD_ROOT/%{_libdir}
 mkdir -p $RPM_BUILD_ROOT/%{_includedir}
 install -m 644 libmimedir.h $RPM_BUILD_ROOT%{_includedir}
-install -m 444 libmimedir.a $RPM_BUILD_ROOT%{_libdir}
-#install -m 775 $RPM_BUILD_ROOT/%{_libdir}/
+install -m 644 libmimedir.a $RPM_BUILD_ROOT%{_libdir}
 rm -f $RPM_BUILD_ROOT%{_libdir}/*.la
-%post -p /sbin/ldconfig
-%postun -p /sbin/ldconfig
 %files static
 %doc README COPYING ChangeLog
 %files devel

Comment 3 Aurelien Bompard 2007-04-28 05:37:46 UTC
New Package CVS Request
Package Name: libmimedir
Short Description: Library to parse MIME Directory Profile
Branches: FC-6

Note You need to log in before you can comment on or make changes to this bug.