Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 226424 - Merge Review: sound-juicer
Summary: Merge Review: sound-juicer
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Matthias Clasen
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 21:00 UTC by Nobody's working on this, feel free to take it
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-08-11 01:31:21 UTC
bdpepple: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 21:00:19 UTC
Fedora Merge Review: sound-juicer

http://cvs.fedora.redhat.com/viewcvs/devel/sound-juicer/
Initial Owner: alexl@redhat.com

Comment 1 Brian Pepple 2007-02-03 17:19:50 UTC
Good:
* Tarball matches upstream.
* Package name conforms to the Fedora Naming Guidelines
* Group Tag is from the official list
* All paths begin with macros
* All necessary BuildRequires listed.
* Package builds in Mock.

Must Fix:
* Source URL is not canonical.
* Missing Package URL. http://www.burtonini.com/blog/computers/sound-juicer
* Sound Juicer shouldn't own the following directories (hicolor-icon-theme
should be the sole owner):
/usr/share/icons/hicolor/16x16
/usr/share/icons/hicolor/16x16/apps
/usr/share/icons/hicolor/22x22
/usr/share/icons/hicolor/22x22/apps
/usr/share/icons/hicolor/22x22
/usr/share/icons/hicolor/22x22/apps
/usr/share/icons/hicolor/scalable
/usr/share/icons/hicolor/scalable/apps

Minor:
* Doesn't use the preferred buildroot:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Duplicate BuildRequires: GConf2-devel (by gnome-media-devel), gtk2-devel (by
gnome-media-devel), gnome-vfs2-devel (by libgnomeui-devel), glib2-devel (by
libgnomeui-devel), hal-devel (by gnome-vfs2-devel)
* Unnecessary Requires on gstreamer, gtk, libmusicbrainz, and glib2. The BR on
the devel packages should pull these in automatically.

Comment 2 Matthias Clasen 2007-02-04 01:13:25 UTC
* Sat Feb  3 2007 Matthias Clasen <mclasen@redhat.com> - 2.16.2-3
- Minor fixes from package review:
 * Remove unnecessary Requires
 * Add URL
 * Correct Source, BuildRoot
 * Fix directory ownership


Comment 3 Brian Pepple 2007-02-04 18:11:21 UTC
Changes look good.  +1 Approved.

Comment 4 Matthias Clasen 2007-08-11 01:31:21 UTC
Review done.


Note You need to log in before you can comment on or make changes to this bug.