Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 226400 - Merge Review: screen
Summary: Merge Review: screen
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Marcela Mašláňová
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 20:56 UTC by Nobody's working on this, feel free to take it
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-02-06 12:16:55 UTC
ed: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 20:56:18 UTC
Fedora Merge Review: screen

http://cvs.fedora.redhat.com/viewcvs/devel/screen/
Initial Owner: mmaslano@redhat.com

Comment 1 Ed Hill 2007-02-03 22:18:58 UTC
Hi folks, here's a quick review:

good:
 + source matches upstream  (where "upstream" 
   apparently == Juergen, not savannah.gnu.org)
 + license is GPL v2 -- OK
 + BuildRoot OK
 + scriptlets OK
 + dir ownership looks OK

needswork:
 - since upstream includes a copy of the license, please 
   include it in %doc

 - please list the license as "GPL", not "GPL2"

rpmlint:
 - rpmlint whines about a few things (the permissions 
   appear to be OK to ignore since screen needs them):
http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/screen-4.0.3-2.fc7.src.rpm/result/rpmlint.log


Please make the two tiny changes above and this package is APPROVED.

Comment 2 Marcela Mašláňová 2007-02-06 12:16:55 UTC
Thank you for your review.


Note You need to log in before you can comment on or make changes to this bug.