Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 226388 - Merge Review: sane-backends
Summary: Merge Review: sane-backends
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nils Philippsen
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 20:54 UTC by Nobody's working on this, feel free to take it
Modified: 2010-02-26 18:26 UTC (History)
1 user (show)

Fixed In Version: sane-backends-1.0.20-12.fc14
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2010-02-26 18:26:34 UTC
nphilipp: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 20:54:29 UTC
Fedora Merge Review: sane-backends

http://cvs.fedora.redhat.com/viewcvs/devel/sane-backends/
Initial Owner: nphilipp@redhat.com

Comment 1 Nils Philippsen 2010-02-26 15:41:12 UTC
http://cvs.fedoraproject.org/viewcvs/devel/sane-backends/

This has been lying around for too long already, I'll do it myself.

Comment 2 Nils Philippsen 2010-02-26 17:09:18 UTC
- PASS: rpmlint

sane-backends.src: W: strange-permission hal-usb-scanner-add 0755

-> bogus: it's an executable script

sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/NEWS
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/plustek/Plustek-PARPORT.txt
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/AUTHORS
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/ChangeLog
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/gt68xx/gt68xx.CHANGES
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/u12/U12.todo
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/plustek/Plustek-USB.txt
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/mustek/mustek.CHANGES
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/plustek/Plustek-PARPORT-TODO.txt
sane-backends.x86_64: W: file-not-utf8 /usr/share/doc/sane-backends-1.0.20/u12/U12.changes

-> convert to UTF-8

sane-backends-devel.x86_64: W: spurious-executable-perm /usr/lib64/pkgconfig/sane-backends.pc

-> fix permissions

sane-backends-libs.x86_64: W: obsolete-not-provided sane-backends

-> required for splitting off libs subpackage

sane-backends-libs.x86_64: W: no-documentation

-> in main package

sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-ma1509.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-canon_pp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-epson2.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-leo.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-dc210.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-pie.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-apple.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-as6e.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-dc25.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-epson.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-umax.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-canon630u.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-teco1.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-coolscan3.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-umax_pp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-avision.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hp3500.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-v4l.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-net.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-nec.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-sm3600.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hp5400.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-mustek_usb2.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-matsushita.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-test.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-umax1220u.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hpljm1005.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hp5590.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-bh.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-canon.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-ibm.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-dc240.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-snapscan.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-sm3840.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-agfafocus.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-coolscan2.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hpsj5s.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-epjitsu.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-genesys.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-niash.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-teco2.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-sp15c.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-st400.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hp4200.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-ricoh.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-artec.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-abaton.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-artec_eplus48u.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-canon_dr.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-mustek_usb.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-sceptre.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-cardscan.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-pixma.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-u12.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-plustek.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-plustek_pp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-xerox_mfp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-coolscan.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-gt68xx.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-teco3.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-sharp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-lexmark.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-microtek.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hs2p.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-qcam.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-stv680.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-microtek2.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-s9036.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-dell1600n_net.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-fujitsu.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-rts8891.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-mustek_pp.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-dll.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-tamarack.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-hp3900.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-mustek.so
sane-backends-libs.x86_64: W: devel-file-in-non-devel-package /usr/lib64/sane/libsane-dmc.so

-> bogus: these are the SANE driver plugins

sane-backends-libs-gphoto2.x86_64: W: spelling-error Summary(en_US) gphoto -> photo, g photo, Photostat

-> bogus: gphoto is a proper name

sane-backends-libs-gphoto2.x86_64: W: no-documentation

-> in main package

5 packages and 0 specfiles checked; 0 errors, 94 warnings.

- GOOD: package is named according to Package Naming Guidelines
- GOOD: spec file named correctly
- GOOD: package meets Packaging Guidelines
- GOOD: licensed with approved license and meets Licensing Guidelines
- GOOD: license field matches actual license
- GOOD: license text contained as documentation
- GOOD: spec file written in American English
- GOOD: spec file is legible
- GOOD: source matches upstream
- GOOD: package already build multiple times in koji
- GOOD: all build dependencies listed
- GOOD: handles locales properly
- GOOD: calls ldconfig
- GOOD: does not bundle copies of system libraries
- N/A: not relocatable
- GOOD: owns all directories it creates
- GOOD: no duplicate file listings
- GOOD: file permissions set properly
- GOOD: has %clean
- GOOD: uses macros consistently
- GOOD: contains code
- N/A: no large documentation
- GOOD: %doc doesn't affect runtime
- GOOD: header files in devel package
- N/A: no static libs
- GOOD: devel package requires pkgconfig
- GOOD: development *.so files in devel package
- GOOD: devel package requires fully versioned main package
- GOOD: removes libtool archives
- N/A: no GUI program
- GOOD: doesn't own files of other packages
- GOOD: removes buildroot in %install
- GOOD: all file names valid UTF-8

--> recommendations:
1. convert documentation files to UTF-8
2. fix permissions on pkgconfig file (needs rework of pkgconfig patch, redo autoreconf patch)

Comment 3 Nils Philippsen 2010-02-26 17:10:45 UTC
(In reply to comment #2)
> sane-backends-devel.x86_64: W: spurious-executable-perm
> /usr/lib64/pkgconfig/sane-backends.pc
> 
> -> fix permissions
[...]
> - GOOD: file permissions set properly

obviously:

BAD: fix permissions on pkgconfig file

Comment 4 Nils Philippsen 2010-02-26 18:26:34 UTC
Issues fixed in sane-backends-1.0.20-12.fc14, approved.


Note You need to log in before you can comment on or make changes to this bug.