Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 226078 - Merge Review: libxklavier
Summary: Merge Review: libxklavier
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-31 19:31 UTC by Nobody's working on this, feel free to take it
Modified: 2009-08-21 09:03 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2009-08-21 09:03:24 UTC
panemade: fedora-review+

Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 19:31:14 UTC
Fedora Merge Review: libxklavier
Initial Owner:

Comment 1 Parag AN(पराग) 2009-07-24 10:45:55 UTC
+ package builds in mock (rawhide i686).
koji Build =>
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
37c6e9fb8b436d6a646a6eea09cf196baad28756  libxklavier-4.0.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ libxklavier.pc file present.
+ -devel subpackage present.
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ ldconfig scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Package  libxklavier-4.0-3.fc12.i686=>
Requires: rtld(GNU_HASH)
+ Package libxklavier-devel-4.0-3.fc12.i686 =>
Provides: pkgconfig(libxklavier) = 4.0
Requires: /usr/bin/pkg-config pkgconfig(libxml-2.0)

+ Not a GUI application

1) follow

Comment 2 Parag AN(पराग) 2009-07-24 10:50:31 UTC
I also don't get why we need
Requires: libxml2-devel
for -devel subpackage?

Comment 3 Matthias Clasen 2009-07-24 19:08:55 UTC
It used to be necessary because the  .pc file has a Requires: libxml-2.0
Nowadays, pkg-config autodeps should take care of it, so it can go.

Comment 4 Parag AN(पराग) 2009-08-07 05:05:10 UTC
There are no blockers for this review.

Note You need to log in before you can comment on or make changes to this bug.