Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 226021 - Merge Review: libgpg-error
Summary: Merge Review: libgpg-error
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2007-01-31 19:23 UTC by Nobody's working on this, feel free to take it
Modified: 2007-12-07 15:47 UTC (History)
1 user (show)

Fixed In Version: 1.6-1
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2007-12-07 15:47:12 UTC
bugs.michael: fedora-review+


Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 19:23:52 UTC
Fedora Merge Review: libgpg-error

http://cvs.fedora.redhat.com/viewcvs/devel/libgpg-error/
Initial Owner: nalin@redhat.com

Comment 1 Michael Schwendt 2007-12-07 09:45:35 UTC
* Version 1.6 is available.


$ rpmlint  /home/qa/tmp/rpm/RPMS/libgpg-error-1.5-6.i386.rpm
libgpg-error.i386: W: file-not-utf8 /usr/share/doc/libgpg-error-1.5/ChangeLog
libgpg-error.i386: W: summary-not-capitalized libgpg-error


> Summary: libgpg-error

Summary: Library for error values used by GnuPG components


> Prereq: /sbin/ldconfig

Requires(post): /sbin/ldconfig
Requires(postun): /sbin/ldconfig


> %makeinstall

Prefer "make DESTDIR=${RPM_BUILD_ROOT} install".


> %doc COPYING COPYING.LIB AUTHORS README INSTALL NEWS ChangeLog

The INSTALL file is irrelevant to RPM package users. It's common
practise not to include it.


> checking for msgfmt... no
> checking for gmsgfmt... :
> checking for xgettext... no
> checking for msgmerge... no

"BuildRequires: gettext" as a safety measure.


* You could enable the tests-suite:

%check
make check


* All minor issues. Hence:

APPROVED


Comment 2 Nalin Dahyabhai 2007-12-07 15:47:12 UTC
Following all suggestions.  Thanks for the review!


Note You need to log in before you can comment on or make changes to this bug.