Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 225703 - Merge Review: docbook-style-dsssl
Summary: Merge Review: docbook-style-dsssl
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-31 18:29 UTC by Nobody's working on this, feel free to take it
Modified: 2010-02-03 09:48 UTC (History)
3 users (show)

Fixed In Version: 1.79-10.fc13
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2010-02-03 09:48:54 UTC
kdudka: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Nobody's working on this, feel free to take it 2007-01-31 18:29:08 UTC
Fedora Merge Review: docbook-style-dsssl
Initial Owner:

Comment 1 Ondrej Vasik 2007-07-27 08:16:57 UTC
Package Change Request
Package Name: docbook-style-dsssl
Updated Fedora Owners:

Comment 2 Kamil Dudka 2010-01-26 15:40:38 UTC
considered OK
- almost silent rpmlint (only some spelling false alarms)
- sane summary/description
- valid project URL and source URL
- upstream tarball is the same as the one from look-aside cache
- md5 hash matches the sources
- dist tag OK
- license tag OK
- %install OK
- %clean OK
- %files OK
- %defattr OK
- %doc OK

may be better
- BuildRoot tag should be %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XXXXXX)

- explicit Requires are not commented as they should be

- missing post/preun dependency on sgml-common

Comment 3 Ondrej Vasik 2010-02-02 11:18:21 UTC
Thanks for review. BuildRoot is harmless, as no longer used - but fixed. Most of the explicit requires no longer needed - as those versions are really ancient now.  Dependency added. Fixed and built as docbook-style-dsssl-1.79-10.fc13.

Comment 4 Kamil Dudka 2010-02-02 11:48:58 UTC
Looks good to me.


Comment 5 Ondrej Vasik 2010-02-03 09:48:54 UTC

Note You need to log in before you can comment on or make changes to this bug.