Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 225447 - Review Request: php-magpierss - MagpieRSS is an RSS parser written in PHP
Summary: Review Request: php-magpierss - MagpieRSS is an RSS parser written in PHP
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Jason Tibbitts
QA Contact: Fedora Package Reviews List
Depends On: 225434
TreeView+ depends on / blocked
Reported: 2007-01-30 17:45 UTC by Michael Stahnke
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-05-24 02:17:39 UTC
tibbs: fedora-review+
wtogami: fedora-cvs+

Attachments (Terms of Use)

Description Michael Stahnke 2007-01-30 17:45:32 UTC
Spec URL:
Description: MagpieRSS is a set of php files designed to parse RSS XML for usage in PHP code.
MagpieRSS is compatible with RSS 0.9 through RSS 1.0.

Comment 1 Michael Stahnke 2007-01-30 18:52:06 UTC
I think I am going to change the install path for this and make the review
dependent on bug #225434.

Comment 3 Jason Tibbitts 2007-05-06 04:03:26 UTC
Well, hey, the blocker bug is fixed now, so I'll take a look.

Comment 4 Jason Tibbitts 2007-05-06 06:16:08 UTC
Well, there's not much to this package.  rpmlint is completely silent.

A couple of minor issues:

The indentation in %description looks a little odd.
There's no need for the leading slash here:

I don't think these are blockers.

* source files match upstream:
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper (none needed)
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-magpierss = 0.72-2.fc7
* %check is not present; no test suite upstream.
* owns the directories it creates.
   /usr/share/php comes from php-common, which is a dependency of php.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.


Comment 5 Michael Stahnke 2007-05-06 16:25:51 UTC
New Package CVS Request
Package Name: php-magpierss
Short Description: MagpieRSS is an RSS parser written in PHP
Branches:  FC-6, F7, devel, EL4, EL5 

Comment 6 Jason Tibbitts 2007-05-15 17:46:38 UTC
Please don't forget to close this bug once the package has been imported and built.

Note You need to log in before you can comment on or make changes to this bug.