Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 222964 - Review Request: dayplanner - A simple time management program.
Summary: Review Request: dayplanner - A simple time management program.
Status: CLOSED DUPLICATE of bug 433488
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2007-01-17 05:09 UTC by Jan Kovats
Modified: 2008-02-27 18:05 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2007-04-13 10:00:13 UTC

Attachments (Terms of Use)

Description Jan Kovats 2007-01-17 05:09:39 UTC
Spec URL:
Description: Day planner is a simple time management program.

Day planner is designed to help you easily manage your time.
It can manage appointments, birthdays and more. It makes sure you
remember your appointments by popping up a dialog box reminding you about it.

This is my first Package and as far as I understand the whole concept I am in the need of a sponsor.

Comment 1 Mamoru TASAKA 2007-01-17 07:20:48 UTC
(Please block both FE-NEW and FE-NEEDSPONSOR)

Comment 2 Jan Kovats 2007-01-17 10:37:27 UTC
(In reply to comment #1)
> (Please block both FE-NEW and FE-NEEDSPONSOR)

Thanks for your help :)

Comment 3 Mamoru TASAKA 2007-02-01 07:05:25 UTC
Well, I must say that your spec file contains
not a few issues to fix.
Please check:

From just I looked at your spec file:

A. Description entry
* Release
  - please add %{?_dist} entry unless you have a reason
    not to do so.
* Source0
  - please specify URL.
* BuildRequires
  - please remove redundant BuildRequires.
    "perl" is in minimum buildroot and required automatically
    by "perl-gettext", so this is not needed.
* %include_holidayparser
  - Currently I don't understand this well. If this package
    can use CPAN Date::HolidayParser module, you should
    not include perl module in this package and should
    submit CPAN module package instead.

B. %build stage
   * Adding %build entry is preferred even if it is completely

C. %install stage
   * "install -mXXX"
    - Use "install -p -mXXX" to keep timestamps.
   * Executable scripts/binaries install directory
    - By the way why do you install 
      "dayplanner dayplanner-daemon dayplanner-notifier" once
      into %{_datadir}/%{name} instead of directly
      installing into %{_bindir}?
   * Desktop file install
   - "install -m644 ./doc/%{name}.desktop"
     Please use desktop-file-install ("Desktop files" entry of

D. scriptlets

   These macros are not defined. Check:

E. file entry
   * macros
   These macros are also undefined.

  * subpackage
  - Would you explain why you want to split dayplanner-commander
    into different subpackage?

Comment 4 Mamoru TASAKA 2007-02-07 07:24:43 UTC

Comment 5 Jan Kovats 2007-02-07 12:59:04 UTC
(In reply to comment #4)
> ping?

I'm very thankfull for all your notes. I looked at Guidlines and tried to do it
right the first time but i fergot a few things as you pointed out.
I didn't answer cause i was busy doing the changes. I didn't have that much time
the past few days.
But i'm soon going to update with and updated spec file and the holiday parser
as a seperate rpm.

Again thanks for taking the time and effort to look through my crude spec.

Comment 6 Mamoru TASAKA 2007-02-25 16:09:00 UTC

Comment 7 Mamoru TASAKA 2007-04-05 08:05:36 UTC
Again ping? I will close this bug in a week unless
any response is made on this bug.

Comment 8 Mamoru TASAKA 2007-04-13 09:59:31 UTC
Closing for now.

If you want to try this software, feel free to reopen
this bug.

Comment 9 Mamoru TASAKA 2008-02-27 18:05:00 UTC

*** This bug has been marked as a duplicate of 433488 ***

Note You need to log in before you can comment on or make changes to this bug.