Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 200665 - Review Request: ltris
Summary: Review Request: ltris
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Thorsten Leemhuis (ignored mailbox)
QA Contact: Fedora Package Reviews List
Depends On:
TreeView+ depends on / blocked
Reported: 2006-07-30 09:12 UTC by Michael J Knox
Modified: 2007-11-30 22:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2006-09-16 20:32:59 UTC

Attachments (Terms of Use)

Description Michael J Knox 2006-07-30 09:12:19 UTC
Spec URL:

LTris is a clone of the tetris game for Linux. It uses a SDL library.

Comment 1 cq92j9y+rlkr0w 2006-07-30 15:51:32 UTC
Hi Michael,

I haven't tried your package, but are you sure you need to run the
'gtk-update-icon-cache' scriptlet? LTris doesn't install icons into

Please correct me if I'm mistaken ;)

Comment 2 Michael J Knox 2006-07-30 19:34:54 UTC
no, you are quiet right. 


Spec URL:

Comment 3 Michał Bentkowski 2006-07-30 19:46:48 UTC
According to you should
package data files and game files separately. Please read whole site and
make necessary changes required by Games Packaging Guidelines.

Comment 4 Michael J Knox 2006-07-30 20:06:31 UTC
The SIG guide states "if possible" not "must". ltris is less than half a meg in
total size. The idea behind splitting the packages, to reduce size, is not
really a concern here IMHO. 

Comment 5 Michał Bentkowski 2006-07-30 20:51:51 UTC
SIG guide also states that this "should be done even if upstream uses one
tarball for game source and data". But for ltris you're probably right.

Comment 6 Wart 2006-07-31 05:27:20 UTC
Requires: SDL_mixer can be dropped.  The package already requires, which is provided by SDL_mixer.

ltris.png is a 48x48 color icon.  Why not put it in the
$RPM_BUILD_ROOT/%{_datadir}/icons/hicolor/48x48/apps/ directory?  I've seem
packages use both, and I'm not sure which is the preferred location for desktop

You define _localstatedir, but never use it.  Drop the %define.

World writable scoreboard files are bad.  I would suggest either of the following:
1) Make the game setgid 'games' and make the scoreboard file 'games' group
writable.  Be sure to audit and modify the code to make sure that it's setgid safe.
2) Move the scoreboard file to $HOME so that it's private for each user.  This
removes the need to use a setgid binary, but also disables having a shared
scoreboard file.

Package creates but doesn't own '/var/games/%{name}'.  Since there's only one
file in this directory, it's acceptable (but not required) to put the scoreboard
file directly in /var/games without the %{name} subdirectory.  I'll update the
Games packaging guidelines to reflect this.

Comment 7 Michael J Knox 2006-07-31 05:38:47 UTC
_localstatedir defines where the scoreboard gets put. I will see how much work
is need to make the scoreboard private to each user. 

Comment 8 Wart 2006-07-31 06:01:30 UTC
(In reply to comment #7)
> _localstatedir defines where the scoreboard gets put.

I see.  Instead of redefining _localstatedir, it would be better just to add
--localstatedir /var/games/%{name} at the end of %configure, instead of
redefining a standard rpm variable which might have unforseen side effects
(though it doesn't seem to in this case).

Comment 9 Michael J Knox 2006-09-16 20:32:59 UTC
Sorry. Due to my stepping out for a while, I am unable to complete this submission.

Note You need to log in before you can comment on or make changes to this bug.