Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1696168 - should replace all "clusteringress" with "ingresscontroller" to avoid confusing
Summary: should replace all "clusteringress" with "ingresscontroller" to avoid confusing
Keywords:
Status: POST
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Routing
Version: 4.1
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ---
: 4.1.0
Assignee: Ravi Sankar
QA Contact: Hongan Li
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-04 09:19 UTC by Hongan Li
Modified: 2019-04-11 07:02 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)

Description Hongan Li 2019-04-04 09:19:35 UTC
Description of problem:
To avoid confusing and keep consistent, we should replace all "clusteringress" with "ingresscontroller", especially those information exposed to user. 

Version-Release number of selected component (if applicable):
4.0.0-0.nightly-2019-04-03-202419

How reproducible:
100%

Steps to Reproduce:
1. cd cluster-ingress-operator/
2. grep -r -i "clusteringress" ./*
3.

Actual results:
---
./pkg/manifests/manifests.go:	OwningClusterIngressLabel = "ingress.openshift.io/clusteringress"
./pkg/operator/controller/controller_router_deployment.go:			return nil, fmt.Errorf("clusteringress %q has invalid spec.routeSelector: %v", ci.Name, err)
./pkg/operator/controller/controller.go:			return fmt.Errorf("failed to remove finalizer from clusteringress %s: %v", ingress.Name, err)
./pkg/operator/controller/controller_dns.go:		log.Info("ensured DNS record for clusteringress", "namespace", ci.Namespace, "name", ci.Name, "record", record)


Expected results:
replace "clusteringress" with "ingresscontroller"

Additional info:

Comment 1 Ravi Sankar 2019-04-09 22:23:58 UTC
Fixed by https://github.com/openshift/cluster-ingress-operator/pull/194


Note You need to log in before you can comment on or make changes to this bug.