Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1695211 - [rebase] restore racy scheduler tests
Summary: [rebase] restore racy scheduler tests
Keywords:
Status: ASSIGNED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Pod
Version: 4.1
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.1.z
Assignee: ravig
QA Contact: Jianwei Hou
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-02 16:28 UTC by David Eads
Modified: 2019-04-04 22:52 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)

Description David Eads 2019-04-02 16:28:00 UTC
Some scheduler unit tests were skipped to avoid races.  They need to be re-enabled.  The commit to revert is https://bugzilla.redhat.com/show_bug.cgi?id=1695207

Comment 1 Seth Jennings 2019-04-04 22:21:29 UTC
the commit link above is not correct.  here is the actually commit link.
https://github.com/openshift/origin/pull/22387/commits/c0c81458fa2130375b7bfd3bea566581f6b1f6e7

it disabled the TestHighProirotyFlushUnschedulableQLeftover test.

Comment 2 Seth Jennings 2019-04-04 22:22:50 UTC
likely fixed by this upstream:
https://github.com/kubernetes/kubernetes/pull/73943

Comment 3 Seth Jennings 2019-04-04 22:52:32 UTC
this is not a blocker.  moving to 4.1.z.  likely will fix itself if we rebase to 1.14.

actually seems like we have the code for PR 73943 in 1.13.. somehow.

lots of upstream changes to that file since 1.13.4

$ git log --no-merges --oneline v1.13.4..upstream/master -- pkg/scheduler/internal/queue/scheduling_queue_test.go
2b554b4286 scheduler: cleanup unused parameters in unschedulableQ
471679f8d2 fix the flake in scheduling_queue_test
df4d65d2e1 Ensure that pods obey backoff timers.
ea9e1a4118 not updae timestamp for each scheduling attempt
ec0739bd03 Fix races in scheduling queue tests
ba47beffd2 Fix weakness of current receivedMoveRequest
28e6bbc175 acquire lock before operating unschedulablepodsmap
de8cfdcd79 add goroutine to move unschedulablepods to activeq regularly
22079a79d4 change sort function of scheduling queue to avoid starvation when unschedulable pods are in the queue
7044145920 Fix race in setting nominated node
48b6f75829 Add pods in the backoff queue to the list of pending pods
fae4f69d36 Fix return value of PriorityQueue.Add.
5e4ccede4c Reschedule with backoff
c821f2ed2f Move scheduling Heap in to scheduler.core.utils
554acf2b38 Change sort function of the scheduling queue to avoid starvation

$ git log --no-merges --oneline upstream/master..v1.13.4 -- pkg/scheduler/internal/queue/scheduling_queue_test.go
6ac7d4be0a Fix weakness of current receivedMoveRequest
06d31c3bd4 add goroutine to move unschedulablepods to activeq regularly
c67c6c86c0 change sort function of scheduling queue to avoid starvation when unschedulable pods are in the queue
67f9528eba Fix race in setting nominated node
eb31bbb8d2 Change sort function of the scheduling queue to avoid starvation

removing 1.13 picks (commit msg that appear on both lists above), this are the commits upstream has that are missing in our base

2b554b4286 scheduler: cleanup unused parameters in unschedulableQ
471679f8d2 fix the flake in scheduling_queue_test
df4d65d2e1 Ensure that pods obey backoff timers.
ea9e1a4118 not updae timestamp for each scheduling attempt
ec0739bd03 Fix races in scheduling queue tests
28e6bbc175 acquire lock before operating unschedulablepodsmap
48b6f75829 Add pods in the backoff queue to the list of pending pods
fae4f69d36 Fix return value of PriorityQueue.Add.
5e4ccede4c Reschedule with backoff
c821f2ed2f Move scheduling Heap in to scheduler.core.utils


Note You need to log in before you can comment on or make changes to this bug.