Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1694938 - gamemode is not working (activated) for games that still use plain libgamemode.so
Summary: gamemode is not working (activated) for games that still use plain libgamemod...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: gamemode
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Christian Kellner
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-02 06:19 UTC by Mikhail
Modified: 2019-04-08 14:14 UTC (History)
2 users (show)

Fixed In Version: gamemode-1.3.1-2.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-04-08 14:14:29 UTC


Attachments (Terms of Use)
screenshot (deleted)
2019-04-02 06:26 UTC, Mikhail
no flags Details

Description Mikhail 2019-04-02 06:19:25 UTC
Description of problem:
For some games I see warning "Current CPU governor may impact performance" even when package gamemode is installed

Version-Release number of selected component (if applicable):
# rpm -q gamemode
gamemode-1.3-1.fc31.x86_64


How reproducible:
Reproducible every time .


Steps to Reproduce:
1. Just launch the game "Rise of the Tomb Raider" from steam launcher.
2.
3.


Expected results:
No "Current CPU governor may impact performance" warning when I launch the game.


Additional info:
The other Feral game "DiRT 4" not affected and with installed gamemode not show this warning.

Comment 1 Mikhail 2019-04-02 06:26:42 UTC
Created attachment 1550887 [details]
screenshot

Comment 2 Alex Smith 2019-04-02 07:57:30 UTC
Looking at the Fedora package contents, it seems there isn't an unversioned library link for the client library (should have /usr/lib*/libgamemode.so linked to libgamemode.so.0).

Before we started using versioned libraries in GameMode (https://github.com/FeralInteractive/gamemode/commit/77d4d0ad237ecb28f772fce979b5126c42cf338f), the client header only attempted to dlopen libgamemode.so, rather than trying libgamemode.so.0 first. Rise of the Tomb Raider was compiled against that older header, so without libgamemode.so, it won't make a request to GameMode.

A libgamemode.so link is created when installing from source so I think this is an issue with the Fedora packages.

Comment 3 Christian Kellner 2019-04-02 08:21:29 UTC
As per the packaging guidelines the ("unversioned") libgaemmode.so is in the -devel package (i.e. gamemode-devel). @Alex, I guess there is no plan to update the "Rise of the Tomb Raider" (or there any other games?) to use the versioned one? I am tempted to move the libgamemode.so link from the -devel package to the main package. For the time being installing the gamemode-devel package is a work-around that should make it work.

Comment 4 Alex Smith 2019-04-02 08:43:33 UTC
From us, Total War: Thrones of Britannia is also affected. No plans for patches to either game right now unfortunately.

Comment 5 Christian Kellner 2019-04-08 14:14:29 UTC
Ok, I have consulted a few others (Bastien, Richard, Peter) and the consensus was that this is unfortunate; and we are just going to ship the libgamemode*.so in the main package for the time being. Alex, it would be great if the games could maybe be updated eventually so we don't have to have that work-around forever ;)

Build is here: https://koji.fedoraproject.org/koji/buildinfo?buildID=1246712


Note You need to log in before you can comment on or make changes to this bug.