Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1694869 - build log output needs polishing
Summary: build log output needs polishing
Keywords:
Status: ASSIGNED
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Containers
Version: 4.1
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
: 4.1.0
Assignee: Tom Sweeney
QA Contact: weiwei jiang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-01 21:46 UTC by Ben Parees
Modified: 2019-04-03 21:15 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Target Upstream Version:


Attachments (Terms of Use)

Description Ben Parees 2019-04-01 21:46:43 UTC
Description of problem:
The default build log output is pretty ugly, particularly with respect to buildah reporting on image pulling/extraction.

here's what we output:

Pulling image image-registry.openshift-image-registry.svc:5000/ci-op-4chgwscr/pipeline:root ...
Getting image source signatures
Copying blob sha256:a02a4930cb5d36f3290eb84f4bfa30668ef2e9fe3a1fb73ec015fc58b9958b17
Copying blob sha256:8a2721be24ba94709a44fdfa852801fe4d908ea5cbca4880cf3d46f15029a07a
Copying blob sha256:f2d8f65b7354a6bdb8a6a7caa3496a8a9890ee46b70153075c56b30bbfcfd8bb
Copying config sha256:8a238b4a88a5ccd47ac730405cda019770499fa09046afa53acffffdab4cc679
Writing manifest to image destination
Storing signatures
8a238b4a88a5ccd47ac730405cda019770499fa09046afa53acffffdab4cc679

Here's what a user needs to know:
Pulling image foo
layer1 pulled
layer2 pulled
layer3 pulled
layer4 pulled
done

They don't need SHAs, they don't care about "writing manifest to image destination", and they definitely don't care about "storing signatures".  I'm also not sure what the final sha being dumped represents (the image sha?), but they won't care about that either.


It's also a little confusing that the Dockerfile execution is interrupted by image pull output:

STEP 1: FROM image-registry.openshift-image-registry.svc:5000/ci-op-4chgwscr/pipeline:root
Getting image source signatures
Copying blob sha256:a02a4930cb5d36f3290eb84f4bfa30668ef2e9fe3a1fb73ec015fc58b9958b17
Copying blob sha256:8a2721be24ba94709a44fdfa852801fe4d908ea5cbca4880cf3d46f15029a07a
Copying blob sha256:f2d8f65b7354a6bdb8a6a7caa3496a8a9890ee46b70153075c56b30bbfcfd8bb
Copying config sha256:8a238b4a88a5ccd47ac730405cda019770499fa09046afa53acffffdab4cc679
Writing manifest to image destination
Storing signatures
STEP 2: ENV "CLONEREFS_OPTIONS"="{\"git_user_email\":\"ci-robot@openshift.io\",\"git_user_name\":\"ci-robot\",\"log\":\"/dev/null\",\"refs\":[{\"org\":\"openshift\",\"repo\":\"origin\",\"base_ref\":\"master\",\"base_sha\":\"0b751606e93258614555c506f9b3aaffefc57723\",\"path_alias\":\"github.com/openshift/origin\"}],\"src_root\":\"/go\"}"
--> d88836ae540f00bff3c64f09773c94e3d5ff78ff9ec2c08350c323111967a88f
STEP 3: FROM d88836ae540f00bff3c64f09773c94e3d5ff78ff9ec2c08350c323111967a88f


as it makes it harder to read the log.  But if the image pull output were cleaner this would be less of an issue.


How reproducible:
Always

Steps to Reproduce:
1. Run a build
2. Look at the output

Actual results:
Messy output that's not relevant to a user


Expected results:
Clean output that means something to the user


Additional Info:
I think all this output comes from buildah, so the logging behavior would need to be updated there.

Comment 1 Adam Kaplan 2019-04-03 13:21:53 UTC
Moving this to the Containers component - this is all coming from buildah.


Note You need to log in before you can comment on or make changes to this bug.