Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1694553 (oidn) - Review Request: oidn - Library of denoising filters for images rendered with ray tracing
Summary: Review Request: oidn - Library of denoising filters for images rendered with ...
Keywords:
Status: POST
Alias: oidn
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vasiliy Glazov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-04-01 05:36 UTC by Luya Tshimbalanga
Modified: 2019-04-02 13:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
vascom2: fedora-review+


Attachments (Terms of Use)

Description Luya Tshimbalanga 2019-04-01 05:36:21 UTC
Spec URL: https://copr-be.cloud.fedoraproject.org/results/luya/LuxCoreRender/fedora-rawhide-x86_64/00876117-oidn/oidn.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/luya/LuxCoreRender/fedora-rawhide-x86_64/00876117-oidn/oidn-0.8.2-1.fc31.src.rpm
Description: An open source library of high-performance, high-quality denoising
filters for images rendered with ray tracing.
Fedora Account System Username: luya

Comment 1 Vasiliy Glazov 2019-04-01 06:44:21 UTC
1. You must move /usr/lib64/libOpenImageDenoise.so to devel subpackage.

2. shared-lib-calls-exit /usr/lib64/libOpenImageDenoise.so.0.8.2 exit@GLIBC_2.2.5
So you should bugreport about this issue to upstream.

3. Large documentation must go in a -doc subpackage. Large could be size(~1MB) or number of files.
  Note: Documentation size is 3420160 bytes in 3 files.
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation

4. Change %{_libdir}/cmake to %{_libdir}/cmake/OpenImageDenoise

5. You should remove rm -rf %{buildroot}

Comment 2 Vasiliy Glazov 2019-04-01 06:47:39 UTC
6. Change %cmake to %cmake .
(With path to curent directory - dot)

Comment 4 Vasiliy Glazov 2019-04-01 08:30:16 UTC
You wrong move libs.
All versioned so-files must be in -libs subpackage. And only unversioned so-file must be in -devel subpackage.

It should be like this:
%files libs
%{_libdir}/cmake/OpenImageDenoise
%{_libdir}/libOpenImageDenoise.so.*

%files devel
%{_includedir}/OpenImageDenoise
%{_libdir}/libOpenImageDenoise.so

Comment 6 Vasiliy Glazov 2019-04-01 09:57:28 UTC
Change
%{_libdir}/libOpenImageDenoise.so*
to
%{_libdir}/libOpenImageDenoise.so.*

Comment 8 Vasiliy Glazov 2019-04-02 06:43:44 UTC
Package appoved.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 3430400 bytes in 3 files.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_documentation


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig not called in %post and %postun for Fedora 28 and later.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License (v2.0)", "*No
     copyright* Apache License (v2.0)", "BSD 3-clause "New" or "Revised"
     License", "Apache License (v2.0) BSD 3-clause "New" or "Revised"
     License". 136 files have unknown license. Detailed output of
     licensecheck in /home/vascom/1694553-oidn/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[!]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in oidn ,
     oidn-libs , oidn-devel , oidn-docs
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
     Note: Arch-ed rpms have a total of 3440640 bytes in /usr/share
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: oidn-0.8.2-3.fc31.x86_64.rpm
          oidn-libs-0.8.2-3.fc31.x86_64.rpm
          oidn-devel-0.8.2-3.fc31.x86_64.rpm
          oidn-docs-0.8.2-3.fc31.x86_64.rpm
          oidn-debuginfo-0.8.2-3.fc31.x86_64.rpm
          oidn-debugsource-0.8.2-3.fc31.x86_64.rpm
          oidn-0.8.2-3.fc31.src.rpm
oidn.x86_64: W: spelling-error Summary(en_US) denoising -> denouncing
oidn.x86_64: W: spelling-error %description -l en_US denoising -> denouncing
oidn.x86_64: W: no-manual-page-for-binary denoise
oidn-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libOpenImageDenoise.so.0.8.2 exit@GLIBC_2.2.5
oidn-libs.x86_64: W: no-documentation
oidn-devel.x86_64: W: no-documentation
oidn.src: W: spelling-error Summary(en_US) denoising -> denouncing
oidn.src: W: spelling-error %description -l en_US denoising -> denouncing
oidn.src:47: W: mixed-use-of-spaces-and-tabs (spaces: line 47, tab: line 1)
7 packages and 0 specfiles checked; 0 errors, 9 warnings.




Rpmlint (debuginfo)
-------------------
Checking: oidn-libs-debuginfo-0.8.2-3.fc31.x86_64.rpm
          oidn-debuginfo-0.8.2-3.fc31.x86_64.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "ru_RU.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "ru_RU.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
	LANGUAGE = (unset),
	LC_ALL = (unset),
	LC_CTYPE = "C.UTF-8",
	LANG = "ru_RU.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
oidn-libs.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
oidn-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libOpenImageDenoise.so.0.8.2 exit@GLIBC_2.2.5
oidn-libs.x86_64: W: no-documentation
oidn-devel.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
oidn-devel.x86_64: W: no-documentation
oidn.x86_64: W: spelling-error Summary(en_US) denoising -> denouncing
oidn.x86_64: W: spelling-error %description -l en_US denoising -> denouncing
oidn.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
oidn.x86_64: W: no-manual-page-for-binary denoise
oidn-debuginfo.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
oidn-docs.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
oidn-debugsource.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
oidn-libs-debuginfo.x86_64: W: invalid-url URL: https://openimagedenoise.github.io/ <urlopen error [Errno -2] Name or service not known>
7 packages and 0 specfiles checked; 0 errors, 13 warnings.



Source checksums
----------------
https://github.com/OpenImageDenoise/oidn/releases/download/v0.8.2/oidn-0.8.2.src.tar.gz :
  CHECKSUM(SHA256) this package     : 788f50535a81387165178d611a0229e58482bb3d950cc4f06e3239481b6981e7
  CHECKSUM(SHA256) upstream package : 788f50535a81387165178d611a0229e58482bb3d950cc4f06e3239481b6981e7


Requires
--------
oidn (rpmlib, GLIBC filtered):
    libOpenImageDenoise.so.0()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    rtld(GNU_HASH)

oidn-libs (rpmlib, GLIBC filtered):
    cmake-filesystem(x86-64)
    ld-linux-x86-64.so.2()(64bit)
    libc.so.6()(64bit)
    libgcc_s.so.1()(64bit)
    libgcc_s.so.1(GCC_3.0)(64bit)
    libm.so.6()(64bit)
    libpthread.so.0()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.7)(64bit)
    libtbb.so.2()(64bit)
    rtld(GNU_HASH)

oidn-devel (rpmlib, GLIBC filtered):
    libOpenImageDenoise.so.0()(64bit)
    oidn-libs(x86-64)

oidn-docs (rpmlib, GLIBC filtered):

oidn-debuginfo (rpmlib, GLIBC filtered):

oidn-debugsource (rpmlib, GLIBC filtered):



Provides
--------
oidn:
    oidn
    oidn(x86-64)

oidn-libs:
    cmake(OpenImageDenoise)
    libOpenImageDenoise.so.0()(64bit)
    oidn-libs
    oidn-libs(x86-64)

oidn-devel:
    oidn-devel
    oidn-devel(x86-64)

oidn-docs:
    oidn-docs
    oidn-docs(x86-64)

oidn-debuginfo:
    debuginfo(build-id)
    oidn-debuginfo
    oidn-debuginfo(x86-64)

oidn-debugsource:
    oidn-debugsource
    oidn-debugsource(x86-64)



Generated by fedora-review 0.7.1 (9643194) last change: 2019-03-21
Command line :/usr/bin/fedora-review -b 1694553
Buildroot used: fedora-rawhide-x86_64
Active plugins: C/C++, Generic, Shell-api
Disabled plugins: Ocaml, R, fonts, Haskell, Perl, SugarActivity, Java, PHP, Python
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH

Comment 9 Vasiliy Glazov 2019-04-02 06:47:22 UTC
I hope in release you add some other changes:

1. Remove tab symbol from line 47. Use only spaces.
2. Make -doc subpackage noarch.
3. License file installed when any subpackage combination is installed. You can add license file to subpackages that can be installed standalone.
4. Make -doc subpackage require -libs or main package so it not should be installed standalone.

Comment 10 Luya Tshimbalanga 2019-04-02 07:48:16 UTC
Thank you. I will

Comment 11 Gwyn Ciesla 2019-04-02 13:56:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/oidn


Note You need to log in before you can comment on or make changes to this bug.