Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1688851 - Review Request: perl-Alien-ProtoBuf - Find Protocol Buffers library
Summary: Review Request: perl-Alien-ProtoBuf - Find Protocol Buffers library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-14 15:20 UTC by Petr Pisar
Modified: 2019-03-15 10:13 UTC (History)
2 users (show)

Fixed In Version: perl-Alien-ProtoBuf-0.08-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-15 10:13:05 UTC
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-03-14 15:20:20 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Alien-ProtoBuf/perl-Alien-ProtoBuf.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Alien-ProtoBuf/perl-Alien-ProtoBuf-0.08-1.fc31.src.rpm
Description:
Depending on Alien::ProtoBuf Perl module ensures the Protocol Buffers library
is installed on your system.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-03-15 09:21:43 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Alien-ProtoBuf-0.08-1.fc31.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Alien::Base)
      1 perl(Alien::ProtoBuf)
      1 perl(Data::Dumper)
      1 perl(Module::Build) >= 0.28
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(parent) 
      1 perl(strict)
      1 perl(warnings)
      1 pkgconfig(protobuf) = 0
Binary requires are almost Ok.
FIX: I didn't find any using of perl(Data::Dumper), please remove it.

$ rpm -qp --provides perl-Alien-ProtoBuf-0.08-1.fc31.noarch.rpm | sort | uniq -c
      1 perl(Alien::ProtoBuf) = 0.08
      1 perl-Alien-ProtoBuf = 0.08-1.fc31
      1 perl(Alien::ProtoBuf::ConfigData)
      1 perl(Alien::ProtoBuf::Install::Files)
Binary provides are Ok.

$ rpmlint ./perl-Alien-ProtoBuf*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please correct 'FIX' issue.

The package looks good.
Resolution: Approved

Comment 2 Petr Pisar 2019-03-15 09:26:49 UTC
The Data::Dumper is used at /usr/share/perl5/vendor_perl/Alien/ProtoBuf/ConfigData.pm:27.

Comment 3 Igor Gnatenko 2019-03-15 09:44:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Alien-ProtoBuf

Comment 4 Petr Pisar 2019-03-15 10:13:05 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.