Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1688740 - sha512sum(1) man page is badly formatted
Summary: sha512sum(1) man page is badly formatted
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: coreutils
Version: 29
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1688744
TreeView+ depends on / blocked
 
Reported: 2019-03-14 10:54 UTC by Jonathan Wakely
Modified: 2019-03-18 12:54 UTC (History)
11 users (show)

Fixed In Version: coreutils-8.31-2.fc31
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1688744 (view as bug list)
Environment:
Last Closed:


Attachments (Terms of Use)
Patch to patch the patch (deleted)
2019-03-14 10:54 UTC, Jonathan Wakely
no flags Details | Diff

Description Jonathan Wakely 2019-03-14 10:54:46 UTC
Created attachment 1543984 [details]
Patch to patch the patch

The coreutils-6.10-manpages.patch screws up the formatting of the man page (and the note it adds to the --help output is not proper English anyway).

The rendered man page looks like:

       -t, --text
              read in text mode (default)

              Note: There is no difference between binary and text mode option
              on GNU system.  -z, --zero           end each output  line  with
              NUL, not newline,

              and disable file name escaping


Note that the -z option is not a new item, but continues on from the note, and there's a spurious line break after "not newline,". In the troff source the problem is a missing .TP macro and a missing newline, but the man page appears to be generated by help2man so it's not as simple as fixing the troff.

Please either drop the patch completely (it seems unnecessary to me) or fix the formatting and the grammar.

I've attached a patch for the patch, which moves the "Note:" to the end, so it doesn't mess up the formatting of the --text and --zero options. I also fixed the grammar.

Comment 1 Jonathan Wakely 2019-03-14 10:59:31 UTC
I forgot to say that the patch was built in a rawhide mock build and all %check tests passed.

Comment 2 Kamil Dudka 2019-03-14 12:09:18 UTC
Thank you for reporting the bug and preparing the patch!  The original patch was applied to fix bug #406981.  I will send the improved version of the patch upstream so that we do not have to keep it forever.  If they reject the patch, I think it is better to drop it.

Comment 3 Kamil Dudka 2019-03-14 14:03:37 UTC
Patch proposed upstream (I only tweaked it not to exceed the 80 chars line length limit):

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=34856

Comment 4 Kamil Dudka 2019-03-18 09:23:29 UTC
upstream commit:

https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=ae61b106

Comment 5 Kamil Dudka 2019-03-18 12:54:25 UTC
fixed in rawhide for now:

https://src.fedoraproject.org/cgit/rpms/coreutils.git/commit/?id=2bc851a4


Note You need to log in before you can comment on or make changes to this bug.