Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1686359 - Ansible tasks are executed even after error is encountered
Summary: Ansible tasks are executed even after error is encountered
Keywords:
Status: NEW
Alias: None
Product: cockpit-ovirt
Classification: oVirt
Component: gluster-ansible
Version: 0.12.2
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ovirt-4.3.4
: ---
Assignee: Gobinda Das
QA Contact: SATHEESARAN
URL:
Whiteboard:
Depends On:
Blocks: 1686357
TreeView+ depends on / blocked
 
Reported: 2019-03-07 10:24 UTC by SATHEESARAN
Modified: 2019-03-28 07:21 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1686357
Environment:
Last Closed:
oVirt Team: Gluster
sasundar: ovirt-4.3?


Attachments (Terms of Use)

Description SATHEESARAN 2019-03-07 10:24:09 UTC
Description of problem:
-----------------------
gluster-ansible roles executes even after the error is encountered.
For example, 512b validation has failed on the disk and ansible task of creating thinpool, lv, creating XFS, just continues even though it identified that the disk is not suitable for RHHI deployment

Version-Release number of selected component (if applicable):
--------------------------------------------------------------
cockpit-ovirt-dashboard-0.12.4

How reproducible:
------------------
Always

Steps to Reproduce:
-------------------
1. Provide a non 512b logical-sized brick for RHHI deployment

Actual results:
---------------
thinpool creation, lv creation, and XFS creation happens on the disk, eventhoughh the flow identifies that the disk is not suitable for RHHI deployment

Expected results:
-----------------
Ansible flow should abort further tasks execution once it finds out an error in the deployment

--- Additional comment from SATHEESARAN on 2019-03-07 10:22:40 UTC ---

Ansible has this option to abort the execution on failure. Thanks Sac for letting us know about it.
https://docs.ansible.com/ansible/latest/user_guide/playbooks_error_handling.html#aborting-the-play

'any_errors_fatal: true' aborts the execution of any other tasks, once the error is encountered.

Comment 1 SATHEESARAN 2019-03-28 07:21:30 UTC
The discussion keep happening in the dependent bug, the last comment is to test with max_fail_percentage to 1 and any_errors_fatal: true


Note You need to log in before you can comment on or make changes to this bug.