Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1685709 - virt-manager: Throws a stack trace when attempting to change VM name
Summary: virt-manager: Throws a stack trace when attempting to change VM name
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: x86_64
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-05 20:59 UTC by LHProjects
Modified: 2019-03-05 22:12 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-05 21:41:29 UTC


Attachments (Terms of Use)
Python stack trace (deleted)
2019-03-05 20:59 UTC, LHProjects
no flags Details

Description LHProjects 2019-03-05 20:59:32 UTC
Created attachment 1541148 [details]
Python stack trace

Description of problem:

After marking 'Customize configuration before install'. Change Chipset and Firmware, click apply, then a stack trace is thrown after you to attempt to change the VM name. See attachment.



Version-Release number of selected component (if applicable):

virt-manager: 2.1.0
libvirt: 5.0.0-1

How reproducible:

Every time.

Steps to Reproduce:
1. Launch Wizard
2. Step 1: Select distro ISO and Generic under 'Choose the operating system'
3: Step 2: Set your memory and number CPUs
4: Step 3: Create a disk image or select custom storage
5: Step 4: Check 'Customize configuration before install'
6: Change Chipset to Q35
7: Change Firmware to 'UEFI x86_64:/usr/share/ovmf/x64/OVMF_CODE.fd'
8: Click Apply

Actual results:

Throws Python stack trace.

Expected results:

Successfully change VM name.

Additional info:

It's possible to change VM name after completing configuration Wizard and navigating to VM information and changing it there.

ll /usr/share/ovmf/x64/OVMF_CODE.fd 
-rw-r--r-- 1 root root 1.9M Aug 24  2018 /usr/share/ovmf/x64/OVMF_CODE.fd

Comment 1 Cole Robinson 2019-03-05 21:41:29 UTC
Thanks for the report. I believe this was just fixed upstream earlier today:

commit b206931eb9644e33b31c3141ba3403993898a090
Author: Pavel Hrdina <phrdina@redhat.com>
Date:   Tue Mar 5 15:49:23 2019 +0100

    virtManager: domain: override rename_domain in vmmDomainVirtinst
    
    If user renames guest in VM details page before installation starts
    there is no need to rename NVRAM file as well.
    
    Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1667308

Comment 2 LHProjects 2019-03-05 22:12:12 UTC
That was quick, thanks a lot. I'll be tracking the repository on Github.


Note You need to log in before you can comment on or make changes to this bug.