Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1685541 - virt-xml when used with --remove-device to remove the first serial device should remove also the console device or vice-versa
Summary: virt-xml when used with --remove-device to remove the first serial device sho...
Keywords:
Status: NEW
Alias: None
Product: Virtualization Tools
Classification: Community
Component: virt-manager
Version: unspecified
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
Assignee: Cole Robinson
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-05 12:51 UTC by Katerina Koukiou
Modified: 2019-03-05 15:29 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Katerina Koukiou 2019-03-05 12:51:29 UTC
Description of problem:
`virt-xml myGuest --remove-device X` can remove only one device element at a call.
However some devices like the first serial and console devices should be removed together otherwise removing one of them will not have any effect to the guest.

How reproducible:
Always

Steps to Reproduce:
1. virt-xml testVm --remove-device --serial pty
2. virt-xml testVm --remove-device --console pty

Actual results:

`virsh dumpxml testVm` to confirm the serial and console pty is still there.

Expected results:
Removing either the serial or the console device should remove both from the guest's XML.
virt-xml should probably special case the  the serial device handling to remove the second device automatically if one the the two is marked for removal.

Comment 1 Cole Robinson 2019-03-05 15:29:07 UTC
We have some special purpose logic for doing this in virtManager/domain.py, we need to get that into virtinst/ somehow it can be shared with virt-xml


Note You need to log in before you can comment on or make changes to this bug.