Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 163760 - mhshow fails to read mhshow-show-text/html from mhn.defaults
Summary: mhshow fails to read mhshow-show-text/html from mhn.defaults
Alias: None
Product: Fedora
Classification: Fedora
Component: nmh
Version: 4
Hardware: i386
OS: Linux
Target Milestone: ---
Assignee: Josh Bressers
QA Contact: Fedora Extras Quality Assurance
: 163763 (view as bug list)
Depends On:
TreeView+ depends on / blocked
Reported: 2005-07-20 20:57 UTC by Joel Uckelman
Modified: 2007-11-30 22:11 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-12-14 02:52:33 UTC

Attachments (Terms of Use)
Patch for nmh-1.1 (deleted)
2005-11-19 10:28 UTC, Michael Forrest
no flags Details | Diff

Description Joel Uckelman 2005-07-20 20:57:03 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5

Description of problem:
If I put the following line in /etc/nmh/nmh.defaults:

 mhshow-show-text/html: %plynx -dump -localhost -force_html -noredir '%F' | less

it is ignored and html messages are shown as raw html. But if I put that same line in my ~/.mh_profile, lynx is called and renders the html. I know that the settings in mhn.defaults aren't all being ignored by mhshow, since whether I have

 mhshow-charset-iso-8859-1: %s

there makes a difference when reading messages with that charset.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Get a message which has Content-type: text/html.
2. mhshow

Actual Results:  mhshow displays a bunch of raw html.

Expected Results:  mhshow should call lynx to render the html.

Additional info:

Comment 1 Joel Uckelman 2005-07-20 21:07:58 UTC
*** Bug 163763 has been marked as a duplicate of this bug. ***

Comment 2 Josh Bressers 2005-07-21 05:03:52 UTC
OK, I've verified this bug.  It's fixed in the upstream CVS.  I'll try to find
the fix in the very near future.

Comment 3 Josh Bressers 2005-09-14 12:37:33 UTC
I've not had time to extract a proper patch, and I no longer plan on doing so. 
There is a new release of nmh on the way, and I'd rather just wait to package
the new versus fixing the old:

Comment 4 Michael Forrest 2005-11-19 10:24:40 UTC
I have a source patch for this very issue, which causes mhshow to effectively
ignore mhn.defaults when at the point of deciding what program to use.

The problem is that the settings read in from mhn.defaults are overwritten
by another call to context_read().

Thius patch short-circuits the secondary call to that function.

Then the mhshow tool of choice is properly obeyed from mhn.defaults.

Comment 5 Michael Forrest 2005-11-19 10:28:39 UTC
Created attachment 121260 [details]
Patch for nmh-1.1

This patch is relatively straightforward fix for this regression (it used to
work way back in RH9!!).

Comment 6 Josh Bressers 2005-12-14 01:46:50 UTC

Thanks for the patch.  I'm sorry this bug has been open for so long, the nmh
release is taking much longer than expected.  I'm checking in this into the nmh
cvs repository tonight.  If there is no 1.2 before the new year, or I need to
roll a new nmh for some reason, I will include this patch.

Comment 7 Josh Bressers 2005-12-14 02:52:33 UTC
I found some time this evening to patch this.  Look for nmh-1.1-14.fc[345] to
show up soon in extras.

Note You need to log in before you can comment on or make changes to this bug.