Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1584840 - Review Request: nodejs-tippex - Find and erase strings and comments in JavaScript code
Summary: Review Request: nodejs-tippex - Find and erase strings and comments in JavaSc...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1584827 1584891 1584700
Blocks: nodejs-reviews mozgw
TreeView+ depends on / blocked
 
Reported: 2018-05-31 19:03 UTC by Jared Smith
Modified: 2018-06-01 15:27 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-06-01 15:27:03 UTC
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Jared Smith 2018-05-31 19:03:12 UTC
Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tippex/nodejs-tippex.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tippex/nodejs-tippex-3.0.0-1.fc29.src.rpm
Description: Find and erase strings and comments in JavaScript code
Fedora Account System Username: jsmith

Comment 1 Robert-André Mauchin 2018-05-31 22:10:30 UTC
Build fails:

Exécution_de(%build) : /bin/sh -e /var/tmp/rpm-tmp.bAAArn
+ umask 022
+ cd /builddir/build/BUILD
+ cd package
+ /usr/lib/rpm/nodejs-symlink-deps /usr/lib/node_modules --build
+ rollup -c
BUILDSTDERR: Error: (buble plugin) Unexpected token (169:39)
BUILDSTDERR: src/index.js (169:39)
BUILDSTDERR: 165 :     if ( char === '/' ) {
BUILDSTDERR: 166 :       const end = i;
BUILDSTDERR: 167 :       const value = str.slice( start, end );
BUILDSTDERR: 168 : 
BUILDSTDERR: 169 :       found.push({ start, end, value, type: 'regex' });
BUILDSTDERR:

Comment 2 Jared Smith 2018-06-01 12:21:00 UTC
Weird, it built on my machine, and I thought I had built it in mock.  Let's try this instead and see if it builds any better:

Spec URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tippex/nodejs-tippex.spec
SRPM URL: https://jsmith.fedorapeople.org/Packaging/nodejs-tippex/nodejs-tippex-3.0.0-2.fc29.src.rpm

Comment 3 Robert-André Mauchin 2018-06-01 13:31:04 UTC
 - Latest version packaged
 - License ok
 - Builds in Mock
 - No rpmlint errors
 - Conforms to the Packaging Guidelines

Package approved.

Comment 4 Jared Smith 2018-06-01 14:21:24 UTC
Repo requested at https://pagure.io/releng/fedora-scm-requests/issue/6854.

Comment 5 Gwyn Ciesla 2018-06-01 14:32:29 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-tippex

Comment 6 Jared Smith 2018-06-01 15:27:03 UTC
Packaged in Rawhide, closing this issue


Note You need to log in before you can comment on or make changes to this bug.