Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 155544 - requeued IO does not have BIO_RW_FAILFAST set.
Summary: requeued IO does not have BIO_RW_FAILFAST set.
Alias: None
Product: Fedora
Classification: Fedora
Component: device-mapper-multipath
Version: rawhide
Hardware: All
OS: Linux
Target Milestone: ---
Assignee: Alasdair Kergon
QA Contact:
Depends On:
TreeView+ depends on / blocked
Reported: 2005-04-21 10:52 UTC by Lars Marowsky-Bree
Modified: 2007-11-30 22:11 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2005-04-21 20:05:29 UTC

Attachments (Terms of Use)
Move setting BIO_RW_FAILFAST to map_io() (deleted)
2005-04-21 10:52 UTC, Lars Marowsky-Bree
no flags Details | Diff

Description Lars Marowsky-Bree 2005-04-21 10:52:34 UTC
dm_bio_restore(), called just before requeuing, restores and overwrites our bio
flags. Attached patchlet fixes this.

Comment 1 Lars Marowsky-Bree 2005-04-21 10:52:35 UTC
Created attachment 113463 [details]
Move setting BIO_RW_FAILFAST to map_io()

Comment 2 Alasdair Kergon 2005-04-21 19:55:04 UTC
where does the overwriting happen?
bio_record.h doesn't touch bi_rw

Comment 3 Lars Marowsky-Bree 2005-04-21 20:05:29 UTC
Brown paper bag. You're right. I got confused by the setting of bi_flags, but
bi_rw_failfast is in a different field as you correctly point out; maybe I was
looking for bugs a little bit _too_ hard.

Closing bug, patch not needed ;)

Note You need to log in before you can comment on or make changes to this bug.