Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1553866 - Review Request: nodejs-libpq - Node native bindings to the PostgreSQL libpq C client library
Summary: Review Request: nodejs-libpq - Node native bindings to the PostgreSQL libpq C...
Keywords:
Status: POST
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: nodejs-reviews
TreeView+ depends on / blocked
 
Reported: 2018-03-09 18:06 UTC by Tom Hughes
Modified: 2018-03-09 19:00 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Tom Hughes 2018-03-09 18:06:19 UTC
Spec URL: http://tomh.fedorapeople.org//nodejs-libpq.spec
SRPM URL: http://tomh.fedorapeople.org//nodejs-libpq-1.8.7-1.fc27.src.rpm

Description:
Node native bindings to the PostgreSQL libpq C client library. This module
attempts to mirror as closely as possible the C API provided by libpq and
provides the absolute minimum level of abstraction. It is intended to be
extremely low level and allow you the same access as you would have to libpq
directly from C, except in node.js! The obvious trade-off for being "close to
the metal" is having to use a very "c style" API in JavaScript.

Comment 1 Tom Hughes 2018-03-09 18:06:24 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=25585484

Comment 2 Robert-André Mauchin 2018-03-09 18:49:56 UTC
 - Tests fail in fedora-review:

+ pg_ctl start -w -D pg_data -l pg_log -o '-k /builddir/build/BUILD/package -p 12345'
waiting for server to start.... done
server started
+ createdb -h /builddir/build/BUILD/package -p 12345 test
+ PGHOST=/builddir/build/BUILD/package
+ PGPORT=12345
+ PGDATABASE=test
+ /usr/bin/mocha -t 10000
  async connection

    ✓ works

    ✓ works with hard-coded connection parameters

    1) returns an error to the callback if connection fails
  2 passing (10s)
  1 failing
  1) async connection returns an error to the callback if connection fails:
     Error: timeout of 10000ms exceeded. Ensure the done() callback is being called in this test.
  
BUILDSTDERR: erreur : Mauvais statut de sortie pour /var/tmp/rpm-tmp.ftIlhM (%check)


Seems to work in Koji though: https://koji.fedoraproject.org/koji/taskinfo?taskID=25585943

Everything else is fine so package approved.

Comment 3 Gwyn Ciesla 2018-03-09 19:00:36 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-libpq


Note You need to log in before you can comment on or make changes to this bug.