Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1519936 - gdm pixbuf loader xbm fails
Summary: gdm pixbuf loader xbm fails
Keywords:
Status: NEW
Alias: None
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: gdk-pixbuf2
Version: 6.9
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: ---
Assignee: Benjamin Otte
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-01 18:10 UTC by Abrahm Scully
Modified: 2017-12-01 18:21 UTC (History)
0 users

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)
fixes backported from upstream (deleted)
2017-12-01 18:10 UTC, Abrahm Scully
no flags Details | Diff
spec file used to test fix (deleted)
2017-12-01 18:11 UTC, Abrahm Scully
no flags Details

Description Abrahm Scully 2017-12-01 18:10:15 UTC
Created attachment 1361715 [details]
fixes backported from upstream

Description of problem:
Upstream bug https://bugzilla.gnome.org/show_bug.cgi?id=573726
Gentoo downstream bug https://bugs.gentoo.org/255422

Version-Release number of selected component (if applicable):
gdk-pixbuf2-2.24.1-6

How reproducible:
100%

Steps to Reproduce:
1. Try to load an XBM file with gdk_pixbuf_new_from_file().

Actual results:
Loader fails because image format not supported.

Expected results:
Loader succeeds because image format is supported.

Additional info:

Comment 2 Abrahm Scully 2017-12-01 18:11:36 UTC
Created attachment 1361716 [details]
spec file used to test fix

Comment 3 Abrahm Scully 2017-12-01 18:13:45 UTC
With the attached spec file and patch, xbm files are loaded correctly again.

Comment 4 Abrahm Scully 2017-12-01 18:21:08 UTC
As an aside, libgio-2.0's file type detection sometimes doesn't detect an .xbm file as "text/plain" if there are comments at the top of the .xbm file. If the .xbm file is detected as a different file type, the attached patch will not help.

For example .xbm files created with The GIMP might have "/* Created with The GIMP */" as the first line of the file. Those are detected as something other than "text/plain" and therefore will not load. The same files load successfully when modified to only contain the #define lines and the byte array.


Note You need to log in before you can comment on or make changes to this bug.