Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1519737 - Please stop using netpbm tools to extract windows icons
Summary: Please stop using netpbm tools to extract windows icons
Keywords:
Status: NEW
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libguestfs
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard W.M. Jones
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-12-01 10:52 UTC by Laurent Bigonville
Modified: 2018-07-18 15:40 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Laurent Bigonville 2017-12-01 10:52:57 UTC
Hi,

In debian/ubuntu netpbm is quite old (and is actually a fork) and is not working properly to extract the icon from the windows VM

Would it be possible to use something else to extract the icon at runtime and drop that dependency against netpbm?

Comment 1 Pino Toscano 2017-12-01 11:51:11 UTC
To be precise: bmptopnm and pnmtopng are used to convert the BMP icon that libguestfs extracts, using icoutils, from Windows XP and 7 guests.
What would be the alternative to do this?  ImageMagick seems a bit heavy...

Also, maybe it would be rather time for Debian to switch back to the upstream netpbm, since maybe the situations that lead to the fork (almost 14 years ago!) changed...

Comment 2 Laurent Bigonville 2017-12-03 14:19:16 UTC
I packaged an up2date version of netpbm (from upstream) in debian experimental especially for libguestfs

But I'm actually concerned about the LICENCE and the lack of proper copyright assignments of some of the utilities (this was the reason of the fork AFAICS)

Comment 3 Pino Toscano 2018-02-07 16:56:54 UTC
(In reply to Laurent Bigonville from comment #2)
> I packaged an up2date version of netpbm (from upstream) in debian
> experimental especially for libguestfs

Is the version in Debian unstable broken in any way? What is the actual issue (which was not mentioned so far)?

> But I'm actually concerned about the LICENCE and the lack of proper
> copyright assignments of some of the utilities (this was the reason of the
> fork AFAICS)

Considering all the other distributions use the upstream netpbm, either its license is suitable for use, or they are all in license trouble.

Comment 4 Laurent Bigonville 2018-02-12 10:52:14 UTC
(In reply to Pino Toscano from comment #3)
> (In reply to Laurent Bigonville from comment #2)
> > I packaged an up2date version of netpbm (from upstream) in debian
> > experimental especially for libguestfs
> 
> Is the version in Debian unstable broken in any way? What is the actual
> issue (which was not mentioned so far)?

I see the following line with the version of netpbm currently in unstable:

libguestfs: command: run: /usr/bin/wrestool -x --type=2 --name=6801 "/tmp/libguestfsStQ6Gw/download2.exe" | /usr/bin/bmptopnm | /usr/bin/pamcut -bottom 54 | /usr/bin/pnmtopng > "/tmp/libguestfsStQ6Gw/windows-7-icon3.png"
bmptopnm: Unrecognized bits per pixel in BMP file header: 32
pamcut: EOF / read error reading magic number
pnmtopng: EOF / read error reading magic number
libguestfs: trace: inspect_get_icon = ""


> > But I'm actually concerned about the LICENCE and the lack of proper
> > copyright assignments of some of the utilities (this was the reason of the
> > fork AFAICS)
> 
> Considering all the other distributions use the upstream netpbm, either its
> license is suitable for use, or they are all in license trouble.

I really don't know about this


Note You need to log in before you can comment on or make changes to this bug.