Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1517363 - Review Request: ongres-scram - Java implementation of Salted Challenge Response Authentication Mechanism (SCRAM)
Summary: Review Request: ongres-scram - Java implementation of Salted Challenge Respon...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Raiskup
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1517115
TreeView+ depends on / blocked
 
Reported: 2017-11-24 16:37 UTC by Augusto Caringi
Modified: 2017-11-27 14:41 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-27 14:41:31 UTC
praiskup: fedora-review+


Attachments (Terms of Use)

Description Augusto Caringi 2017-11-24 16:37:44 UTC
Spec URL: https://fedorapeople.org/~acaringi/ongres-scram/20171124/ongres-scram.spec
SRPM URL: https://fedorapeople.org/~acaringi/ongres-scram/20171124/ongres-scram-1.0.0~beta.2-1.fc27.src.rpm

Description: 
This is a Java implementation of SCRAM (Salted Challenge Response Authentication Mechanism) which is part of the family of Simple Authentication and Security Layer (SASL, RFC 4422) authentication mechanisms. It is described as part of RFC 5802 and RFC7677.

Fedora Account System Username: acaringi

Comment 1 Pavel Raiskup 2017-11-24 17:14:16 UTC
There are only RPMlint issues:
ongres-scram.noarch: E: description-line-too-long C This is a Java implementation of SCRAM (Salted Challenge Response Authentication Mechanism) which
ongres-scram.noarch: E: description-line-too-long C is part of the family of Simple Authentication and Security Layer (SASL, RFC 4422) authentication

Otherwise it looks good to me, I'll post review.txt in a second.

Comment 3 Pavel Raiskup 2017-11-24 17:25:55 UTC
Thank you, looks good to me.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "BSD (2 clause)". Detailed output of licensecheck in
     /home/praiskup/1517363-ongres-scram/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr/share/maven-metadata
praiskup: all packages require javapackages-tools.
[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/javadoc, /usr,
     /usr/share/licenses, /usr/share/maven-metadata, /usr/share,
     /usr/share/java, /usr/share/maven-poms
praiskup: ditto ^^
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
     Note: Maven packages do not need to (Build)Require jpackage-utils. It
     is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
     subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
     when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
     utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in ongres-
     scram-client , ongres-scram-javadoc , ongres-scram-parent
[?]: Package functions as described.
[x]: Latest version is packaged.
praiskup: beta, that's fine since theres tilde, 1.0.0 >= 1.0.0~beta
[x]: Package does not include license text files separate from upstream.
[?]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
praiskup: this is java package, tests are part of package build
[-]: Packages should try to preserve timestamps of original installed
     files.
praiskup: done an automatic way... (mvn build)
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Java:
[x]: Package uses upstream build method (ant/maven/etc.)
[x]: Packages are noarch unless they use JNI

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: ongres-scram-1.0.0~beta.2-1.fc28.noarch.rpm
          ongres-scram-client-1.0.0~beta.2-1.fc28.noarch.rpm
          ongres-scram-javadoc-1.0.0~beta.2-1.fc28.noarch.rpm
          ongres-scram-parent-1.0.0~beta.2-1.fc28.noarch.rpm
          ongres-scram-1.0.0~beta.2-1.fc28.src.rpm
ongres-scram.noarch: E: description-line-too-long C This is a Java implementation of SCRAM (Salted Challenge Response Authentication Mechanism) which
ongres-scram.noarch: E: description-line-too-long C is part of the family of Simple Authentication and Security Layer (SASL, RFC 4422) authentication
ongres-scram.noarch: W: no-documentation
ongres-scram-client.noarch: W: no-documentation
ongres-scram-parent.noarch: W: summary-not-capitalized C ongres-scram Parent POM
ongres-scram-parent.noarch: W: no-documentation
ongres-scram.src: E: description-line-too-long C This is a Java implementation of SCRAM (Salted Challenge Response Authentication Mechanism) which
ongres-scram.src: E: description-line-too-long C is part of the family of Simple Authentication and Security Layer (SASL, RFC 4422) authentication
5 packages and 0 specfiles checked; 4 errors, 4 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
ongres-scram (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools

ongres-scram-javadoc (rpmlib, GLIBC filtered):
    javapackages-tools

ongres-scram-client (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(com.ongres.scram:common)

ongres-scram-parent (rpmlib, GLIBC filtered):
    java-headless
    javapackages-tools
    mvn(org.apache.maven.plugins:maven-compiler-plugin)
    mvn(org.apache.maven.plugins:maven-javadoc-plugin)



Provides
--------
ongres-scram:
    mvn(com.ongres.scram:common)
    mvn(com.ongres.scram:common:pom:)
    ongres-scram

ongres-scram-javadoc:
    ongres-scram-javadoc

ongres-scram-client:
    mvn(com.ongres.scram:client)
    mvn(com.ongres.scram:client:pom:)
    ongres-scram-client

ongres-scram-parent:
    mvn(com.ongres.scram:parent:pom:)
    ongres-scram-parent



Source checksums
----------------
https://github.com/ongres/scram/archive/1.0.0-beta.2.tar.gz :
  CHECKSUM(SHA256) this package     : 51ad666f33cd3553d3643319b79af348b5106220aee16625e3be72ed377c48c9
  CHECKSUM(SHA256) upstream package : 51ad666f33cd3553d3643319b79af348b5106220aee16625e3be72ed377c48c9

Comment 4 Gwyn Ciesla 2017-11-27 13:56:23 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/ongres-scram


Note You need to log in before you can comment on or make changes to this bug.