Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1513040 - Create rpm macro %{_modprobedir} in /usr/lib/rpm/macros.d/macros.kmod
Summary: Create rpm macro %{_modprobedir} in /usr/lib/rpm/macros.d/macros.kmod
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: kmod
Version: 28
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: kmod development team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-14 16:07 UTC by Jaroslav Kysela
Modified: 2018-02-20 15:32 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Jaroslav Kysela 2017-11-14 16:07:03 UTC
Description of problem:

Some packages (alsa-lib, b43-openfwwf, hwdata) use hardcoded path /lib/modprobe.d for the additional modprobe configuration files. It would be more appropriate to use the path defined by a rpm macro. Example of rpmlint errors:

alsa-lib.src:108: E: hardcoded-library-path in /lib/modprobe.d/dist-*

Example contents of macros.kmod file:

  # RPM macros for packages with additional kernel module configurations

  %_depmodconfdir %{_sysconfdir}/depmod.d
  %_modprobeconfdir %{_sysconfdir}/modprobe.d
  %_modprobedir /lib/modprobe.d

Note:

The kmod package should create also usr/lib/rpm/macros.d directory in case when the rpm package is not installed! See selinux-policy for example:

  $ rpm -qf /usr/lib/rpm/macros.d
  javapackages-tools-4.7.0-17.fc26.noarch
  selinux-policy-3.13.1-260.13.fc26.noarch
  rpm-4.13.0.2-1.fc26.x86_64

Comment 1 Josh Boyer 2017-11-15 17:55:20 UTC
Why would we do this in the kmod package itself, vs in redhat-rpm-config?  We already ship some kmod related files in the latter, so it would make more sense to consolidate that there.  Plus, this seems to be a distro-specific change not something directly related to kmod, correct?

Comment 2 Jaroslav Kysela 2017-11-15 18:26:57 UTC
It's just a proposal. Anyway, systemd (and many other core-system packages) like systemd and selinux-policy contains those macros, too. And I believe that's the purpose of the /usr/lib/rpm/macros.d directory. The kmod package uses those paths, so it should define them, too.

I added Florian for comments.

Comment 3 Fedora End Of Life 2018-02-20 15:32:32 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 28 development cycle.
Changing version to '28'.


Note You need to log in before you can comment on or make changes to this bug.