Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1510559 - Review Request: boost - The free peer-reviewed portable C++ source libraries
Summary: Review Request: boost - The free peer-reviewed portable C++ source libraries
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora Modules
Classification: Fedora
Component: Module Review
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Stephen Gallagher
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2017-11-07 16:37 UTC by Marek Skalický
Modified: 2017-11-08 09:57 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-11-08 09:57:09 UTC
sgallagh: fedora-review+


Attachments (Terms of Use)

Description Marek Skalický 2017-11-07 16:37:00 UTC
Modulemd URL: https://mskalick.fedorapeople.org/boost-module/boost.yaml
Description: The free peer-reviewed portable C++ source libraries
Fedora Account System Username: mskalick

Comment 1 Stephen Gallagher 2017-11-07 17:13:13 UTC
Review comments:

# Blocking
* The MBS doesn't currently populate the content licenses fields yet, so please add the licenses for the content SRPMs.
* The API needs to list all of the boost subpackages that we plan to support. Please also make sure that anything you have here has its dependencies satisfied by something under "requires:" or else is added to this module. If we don't plan to support them (or they pull in too many deps), please filter some of the subpackages out.
* Please filter out python-nose and numpy if they are only build-time dependencies.

# Non-blocking
* I don't think a default profile makes sense for libraries. Default should just be to enable the module.
* We should add a 'development' profile that pulls in boost-devel.

Comment 2 Marek Skalický 2017-11-07 17:47:11 UTC
(In reply to Stephen Gallagher from comment #1)
> Review comments:
> 
> # Blocking
> * The MBS doesn't currently populate the content licenses fields yet, so
> please add the licenses for the content SRPMs.

DONE.

> * The API needs to list all of the boost subpackages that we plan to
> support. Please also make sure that anything you have here has its
> dependencies satisfied by something under "requires:" or else is added to
> this module. If we don't plan to support them (or they pull in too many
> deps), please filter some of the subpackages out.

Boost is widely used library. So can't guess which sub-packages will be required. So I've added all subpackages of boost. Their debuginfo packages aren't list in API nor filtered.
All their requirements should be satisfied by platform module. 

> * Please filter out python-nose and numpy if they are only build-time
> dependencies.

They aren't build dependencies. So I've fixed rationales.

Numpy is required by boost-numpy. And python-nose and openblas are required by numpy. Unneeded sub-packages are filtered.

> 
> # Non-blocking
> * I don't think a default profile makes sense for libraries. Default should
> just be to enable the module.

Makes sense.

> * We should add a 'development' profile that pulls in boost-devel.

I was considering this. I decided that every package that needs boost-devel for building have boost-devel in buildrequirements (so no change from user POV).

But if it is preferred, I've added it.

Comment 3 Stephen Gallagher 2017-11-07 17:58:41 UTC
Thanks, the changes look good to me. My rationale for the development profile is mainly for anyone looking to actually develop boost-based software, not just for using it as a build dependency.

Module is approved. Please request an appropriately-named version branch.

Comment 4 Marek Skalický 2017-11-07 19:09:41 UTC
Thanks for quick review.

SCM request - https://pagure.io/releng/fedora-scm-requests/issue/2750

Comment 5 Gwyn Ciesla 2017-11-07 19:48:18 UTC
(fedrepo-req-admin):  The Pagure repository was created at https://src.fedoraproject.org/modules/boost

Comment 6 Marek Skalický 2017-11-08 09:57:09 UTC
Module is built now.


Note You need to log in before you can comment on or make changes to this bug.