Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1488615 - New Package: python-novajoin-tests-tempest
Summary: New Package: python-novajoin-tests-tempest
Alias: None
Product: RDO
Classification: Community
Component: Package Review
Version: trunk
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: trunk
Assignee: Chandan Kumar
QA Contact: hguemar
Depends On: RDO-QUEENS
Blocks: 1538557
TreeView+ depends on / blocked
Reported: 2017-09-05 20:34 UTC by Ade Lee
Modified: 2018-01-25 11:37 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Last Closed: 2017-12-12 14:03:42 UTC
chkumar: rdo-review+

Attachments (Terms of Use)

Description Ade Lee 2017-09-05 20:34:06 UTC
Description of problem:

novajoin-tempest-plugin is being added upstream. I've added a preliminary spec here:

Comment 1 Javier Peña 2017-09-06 07:58:09 UTC
Initial licensecheck output:

$ licensecheck -r .
./HACKING.rst: *No copyright* UNKNOWN
./LICENSE: *No copyright* Apache (v2.0)
./README.rst: *No copyright* UNKNOWN
./requirements.txt: *No copyright* UNKNOWN
./setup.cfg: *No copyright* Apache
./ Apache (v2.0) GENERATED FILE
./test-requirements.txt: *No copyright* UNKNOWN
./tox.ini: *No copyright* UNKNOWN
./novajoin_tempest_plugin/README.rst: *No copyright* UNKNOWN
./novajoin_tempest_plugin/ *No copyright* Apache (v2.0)
./novajoin_tempest_plugin/ Apache (v2.0)
./novajoin_tempest_plugin/ Apache (v2.0)
./novajoin_tempest_plugin/ Apache (v2.0)
./novajoin_tempest_plugin/ipa/ Apache (v2.0)
./novajoin_tempest_plugin/tests/ Apache (v2.0)
./novajoin_tempest_plugin/tests/ *No copyright* Apache (v2.0)
./novajoin_tempest_plugin/tests/scenario/ Apache (v2.0)
./novajoin_tempest_plugin/tests/scenario/ Apache (v2.0) GENERATED FILE
./novajoin_tempest_plugin/tests/scenario/ Apache (v2.0)
./novajoin_tempest_plugin/tests/scenario/ Apache (v2.0)
./novajoin_tempest_plugin/tests/scenario/ Apache (v2.0)

The package is licensed using the Apache 2.0 license.

Comment 2 Chandan Kumar 2017-09-06 08:10:43 UTC
Hello Ade,

Thanks for submitting the package review.
novajoin-tempest-plugin dist-git created:

Please send the RDO gerrit review for initial package import.


Chandan Kumar

Comment 3 Ade Lee 2017-09-06 16:03:56 UTC
Initial package import review:

Haven't figured out yet why its failing.

Comment 4 Ade Lee 2017-09-08 13:51:27 UTC
Initial package import passing now.

Comment 6 Chandan Kumar 2017-09-26 12:56:51 UTC
Here is the final package review:

The fedora-review look good. 
rpmlint error: 
python2-novajoin-tests-tempest.noarch: E: explicit-lib-dependency python2-ipalib can be fixed in a new patchset.
The package is APPROVED now.

Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.png is marked as %doc instead of %license

===== MUST items =====

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
     (v2.0)". 2 files have unknown license. Detailed output of licensecheck
     in /home/vagrant/rdo_packaging/package_review/python-novajoin-tests-
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Python eggs must not download any dependencies during the build
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

[x]: Avoid bundling fonts in non-fonts packages.
     Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2
     -novajoin-tests-tempest , python-novajoin-tests-tempest-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Spec use %global instead of %define unless justified.
     Note: %define requiring justification: %define upstream_version
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.

===== EXTRA items =====

[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).

Checking: python2-novajoin-tests-tempest-0.0.1-0.20170925155923.59d7ba6.el7.centos.noarch.rpm
python2-novajoin-tests-tempest.noarch: E: explicit-lib-dependency python2-ipalib
python2-novajoin-tests-tempest.noarch: E: no-changelogname-tag
python2-novajoin-tests-tempest.noarch: W: no-documentation
python-novajoin-tests-tempest-doc.noarch: W: summary-not-capitalized C python-novajoin-tests-tempest documentation
python-novajoin-tests-tempest-doc.noarch: E: no-changelogname-tag
python-novajoin-tests-tempest.src: E: no-changelogname-tag
python-novajoin-tests-tempest.src: W: invalid-url Source0: novajoin_tempest_plugin-0.0.1.dev32-0.20170925155923.59d7ba6.tar.gz
3 packages and 0 specfiles checked; 4 errors, 3 warnings.

Rpmlint (installed packages)
python2-novajoin-tests-tempest.noarch: E: explicit-lib-dependency python2-ipalib
python2-novajoin-tests-tempest.noarch: E: no-changelogname-tag
python2-novajoin-tests-tempest.noarch: W: no-documentation
python-novajoin-tests-tempest-doc.noarch: W: summary-not-capitalized C python-novajoin-tests-tempest documentation
python-novajoin-tests-tempest-doc.noarch: E: no-changelogname-tag
2 packages and 0 specfiles checked; 3 errors, 2 warnings.

python2-novajoin-tests-tempest (rpmlib, GLIBC filtered):

python-novajoin-tests-tempest-doc (rpmlib, GLIBC filtered):



Generated by fedora-review 0.5.3 (bcf15e3) last change: 2015-05-04
Command line :/usr/bin/fedora-review -m dlrn-1 -r -b 1488615
Buildroot used: dlrn-centos7-x86_64-1
Active plugins: Python, Generic, Shell-api
Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby

Note You need to log in before you can comment on or make changes to this bug.