Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1379393 (pavucontrol-qt) - Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
Summary: Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: pavucontrol-qt
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Rex Dieter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: qt-reviews
TreeView+ depends on / blocked
 
Reported: 2016-09-26 14:54 UTC by Helio Chissini de Castro
Modified: 2016-10-07 11:42 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-10-07 11:42:17 UTC
rdieter: fedora-review+


Attachments (Terms of Use)

Description Helio Chissini de Castro 2016-09-26 14:54:41 UTC
Spec URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt.spec
SRPM URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt-0.1.0-1.fc24.src.rpm
Description: Qt port of volume control pavucontrol
Fedora Account System Username: heliocastro

Comment 1 Rex Dieter 2016-09-26 14:58:00 UTC
I can review today (or tomorrow)

Comment 2 Rex Dieter 2016-09-26 17:33:00 UTC
naming: ok

license: ok

1.  could/should leave out:
BuildRequires: %{?fedora:cmake}%{!?fedora:cmake3} >= 3.0
that dependency should be handled by whatever package that provides the 
%{cmake_lxqt} 
macro

macros: ok

2.  should consider adjusting pavucontrol-qt.desktop Name/GenericNameComment somehow, it currently appears exactly the same as pavucontrol, so it's hard/impossible to distinguish which is which, contains:
Name=PulseAudio Volume Control
GenericName=Volume Control
Comment=Adjust the volume level
(not a blocker, mostly a suggestion for pavucontrol-qt upstream)

scriptlets: ok (n/a)

sources: ok
32217c5ae8a846e92548a55b8d3b9267  pavucontrol-qt-0.1.0.tar.xz


otherwise, package is fairly simple and clean, 
APPROVED


Note You need to log in before you can comment on or make changes to this bug.