Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1365903 - virt-admin reports a message indicating success when it fails to connect
Summary: virt-admin reports a message indicating success when it fails to connect
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.3
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: rc
: ---
Assignee: Erik Skultety
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-10 12:53 UTC by Erik Skultety
Modified: 2016-11-03 18:52 UTC (History)
4 users (show)

Fixed In Version: libvirt-2.0.0-5.el7
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 18:52:11 UTC


Attachments (Terms of Use)


Links
System ID Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2577 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2016-11-03 12:07:06 UTC

Description Erik Skultety 2016-08-10 12:53:01 UTC
Description of problem:
When virt-admin fails to connect, e.g. due to an invalid URI, it does report an error stating that it failed to connect but at the same time it reports a message indicating that the connection establishment went just fine.

Version-Release number of selected component (if applicable):
libvirt-2.0.0 and up

How reproducible:
Always.

Steps to Reproduce:
1. launch virt-admin and try to connect to an invalid URI
 # virt-admin connect foobar
 error: Failed to connect to the admin server
 Connected to the admin server
 error: unsupported configuration: Unsupported URI scheme '<null>'

Actual results:
As the output indicates, the client apparently both failed an succeeded to connect to the given URI.

Expected results:
The output of virt-admin only reports an error in the above case.

Comment 1 Erik Skultety 2016-08-10 13:34:18 UTC
Fixed upstream by:

commit 4914494eb8e25ff7938a12fd089c746ec6042bbb
Author:     Erik Skultety <eskultet@redhat.com>
AuthorDate: Tue Aug 9 16:11:26 2016 +0200
Commit:     Erik Skultety <eskultet@redhat.com>
CommitDate: Wed Aug 10 15:24:07 2016 +0200

    virt-admin: Fix the error when an invalid URI has been provided
    
    After commit 9d479dd1 fiddled with the cmdConnect's output which used to be a
    bit more verbose prior to the mentioned commit, the program flow would result
    in a quite confusing error if an invalid URI has been provided:
    
        error: Failed to connect to the admin server
        Connected to the admin server
        error: <some error>
    
    The problem is that the commit mentioned above relied on the fact that
    connect routine always succeeds which is not true.
    
    Signed-off-by: Erik Skultety <eskultet@redhat.com>

Comment 4 Fangge Jin 2016-08-15 03:44:25 UTC
Reproduced on build libvirt-2.0.0-4.el7.x86_64

# virt-admin connect aaa
error: Failed to connect to the admin server
Connected to the admin server
error: unsupported configuration: Unsupported URI scheme '<null>'


Verify on build libvirt-2.0.0-5.el7.x86_64
# virt-admin connect aaa
error: Failed to connect to the admin server
error: unsupported configuration: Unsupported URI scheme '<null>'

# echo $?
1

Comment 6 errata-xmlrpc 2016-11-03 18:52:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html


Note You need to log in before you can comment on or make changes to this bug.