Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1365258 - fstab syntax highlighting
Summary: fstab syntax highlighting
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: vim
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Karsten Hopp
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-08 17:44 UTC by Subhendu Ghosh
Modified: 2016-12-15 10:01 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-12-15 10:01:34 UTC


Attachments (Terms of Use)

Description Subhendu Ghosh 2016-08-08 17:44:29 UTC
Description of problem:
/usr/share/vim/vim74/syntax/fstab.vim does not support GPT partition naming in the syntax highlighting. In particular PARTLABEL and PARTUUID should be support as Devices, but are not.

Version-Release number of selected component (if applicable):
vim-common-7.4.1868-1.fc24.x86_64

How reproducible:
always

Steps to Reproduce:
1. edit /etc/fstab
2. create an entry using PARTLABEL or PARTUUID
3. 

Actual results:
PARTLABEL and PARTUUID terms are not recognized as valid Device types even though both "mount" and "fstab" support their usage.

Expected results:


Additional info:
--- fstab.vim	2016-08-08 13:43:23.949785256 -0400
+++ fstab2.vim	2016-08-08 13:42:59.125155158 -0400
@@ -37,6 +37,8 @@
 syn cluster fsDeviceCluster contains=fsOperator,fsDeviceKeyword,fsDeviceError
 syn match fsDeviceError /\%([^a-zA-Z0-9_\/#@:\.-]\|^\w\{-}\ze\W\)/ contained
 syn keyword fsDeviceKeyword contained none proc linproc tmpfs devpts devtmpfs sysfs usbfs
+syn keyword fsDeviceKeyword contained PARTLABEL nextgroup=fsDeviceLabel
+syn keyword fsDeviceKeyword contained PARTUUID nextgroup=fsDeviceUUID
 syn keyword fsDeviceKeyword contained LABEL nextgroup=fsDeviceLabel
 syn keyword fsDeviceKeyword contained UUID nextgroup=fsDeviceUUID
 syn keyword fsDeviceKeyword contained sshfs nextgroup=fsDeviceSshfs

Comment 2 Karsten Hopp 2016-12-15 10:01:34 UTC
I've added the patch to git so that it'll be automatically fixed in the next vim update.


Note You need to log in before you can comment on or make changes to this bug.