Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1362491 - Review Request: phabricator - Phabricator, an open software engineering platform
Summary: Review Request: phabricator - Phabricator, an open software engineering platform
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1362487 1362490
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-08-02 11:07 UTC by Jeroen van Meeuwen
Modified: 2017-10-05 15:41 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description Jeroen van Meeuwen 2016-08-02 11:07:18 UTC
Spec URL: https://kanarip.fedorapeople.org/phabricator/phabricator.spec
SRPM URL: https://kanarip.fedorapeople.org/phabricator/phabricator-20160710.git9da15fd-2.1.el7.src.rpm
Description: Phabricator is a collection of open source web applications that help software companies build better software.
Fedora Account System Username: kanarip

Comment 1 Jeroen van Meeuwen 2016-08-02 11:10:43 UTC
Please note that this package may need a bunch of work, including but not limited to the items already collected through analysis from Tim.

https://bitbucket.org/tflink/phabricator-dist/raw/c21a9d58b00f94fce779ba8b2d01bd54bae8195a/fedora-packaging-notes.rst

Comment 2 Jeroen van Meeuwen 2016-08-10 11:04:49 UTC
To show my general plan for unbundling software; strip the feature if you can (twilio, stripe, amazon-ses), use the packaged versions where appropriate (figlet, pear-figlet), package the software where appropriate (not yet started).

Spec URL: https://kanarip.fedorapeople.org/phabricator/phabricator.spec
SRPM URL: https://kanarip.fedorapeople.org/phabricator/phabricator-20160806.git435f756-1.fc26.src.rpm

Comment 5 Robert-André Mauchin 2017-10-05 15:41:46 UTC
Hello,

I'm not familiar with EPEL requirements, so ignore the things not applying to it.

 - Not needed in Fedora:

   + Group:

   + rm -rf %{buildroot} in %install

   + %clean
     rm -rf %{buildroot}

   + %{!?_licensedir:%global license %doc}

 See: https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

 - Maybe you should refresh to a more recent git revision.

 - Use systemd macros, use:

%{?systemd_requires}
BuildRequires: systemd

   instead of:

Requires(post):     systemd-units
Requires(postun):   systemd-units
Requires(preun):    systemd-units

BuildRequires:      systemd

 - You should probably clean up all the commented out part.

 - The release tag should start with 0.1 and so on:

Version:            0.1.%{revision_date}.git%{git_short_version_hash}


Note You need to log in before you can comment on or make changes to this bug.