Note: This is a beta release of Red Hat Bugzilla 5.0. The data contained within is a snapshot of the live data so any changes you make will not be reflected in the production Bugzilla. Also email is disabled so feel free to test any aspect of the site that you want. File any problems you find or give feedback here.
Bug 1361672 - Review Request: python-fmn-sse - allows fedora users to view their fedmsg feed in realtime
Summary: Review Request: python-fmn-sse - allows fedora users to view their fedmsg fee...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-07-29 17:15 UTC by skrzepto
Modified: 2016-08-01 14:48 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:


Attachments (Terms of Use)

Description skrzepto 2016-07-29 17:15:51 UTC
Spec URL: https://raw.githubusercontent.com/fedora-infra/fmn.sse/master/python-fmn-sse.spec
SRPM URL: https://github.com/fedora-infra/fmn.sse/blob/fedora_pkg_review/python-fmn-sse-0.1.0-1.fc24.src.rpm?raw=true
Description: FMN is a family of systems to manage end-user notifications triggered by fedmsg, the Fedora Federated Message bus.FMN.SSE allows fedora users to view their fedmsg feed in realtime.
Fedora Account System Username: skrzepto

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-08-01 14:48:39 UTC
The Summary is good, but the %description is a bit lacking: after reading it, I still don't know *what* this package does... I think you should spell it out in simple words.

No need to define %sum: just write the first Summary in full, and then you can refer to that text as %summary.

License tag needs a specific version for GPL. It needs to be one of the "short names" in https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses.

.egg-info doesn't need to be removed [https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/FOG5APDRQVNXR5ZOZZSVDNZVN4WURKG4/].

It doesn't work with python3? It would be nicer to package it as a Python3 application if possible.

I think that systemd-devel is probably not required. It is only used to compile C programs linked with the systemd libs.

python-fmn-sse.noarch: W: incoherent-version-in-changelog 0.1 ['0.1.0-1.fc24', '0.1.0-1']
python-fmn-sse.noarch: W: summary-ended-with-dot C FMN.SSE allows fedora users to view their fedmsg feed in realtime.

About the service file: the service most likely shouldn't run as root. Running a network-facing web server with full privileges is crazy. You should add a dedicated user (fmn-sse or similar) in %pre.

--

OK, after reading the spec and looking at the files, the biggest issues are:
- can you provide a better overview in %description what the intent of this package is, this will make further review easier.
- there needs to be some instructions how to enable the service. In particular I have no idea what the instance argument to the template should be.
- the service should run with reduced privileges.


Note You need to log in before you can comment on or make changes to this bug.